Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to conditionally load semantic_puppet anymore? #141

Open
binford2k opened this issue Jun 18, 2024 · 2 comments
Open

Do we need to conditionally load semantic_puppet anymore? #141

binford2k opened this issue Jun 18, 2024 · 2 comments

Comments

@binford2k
Copy link
Member

Do we need this reimplementation? 923f567

@bastelfreak
Copy link
Member

I don't see a reason to keep it. Do you want to revert the old commit?

@ekohl
Copy link
Member

ekohl commented Jun 19, 2024

I don't see why. The commit you refer to comes from a time when Puppet had vendored SemanticPuppet and you could only load one or the other. The vendored implementation has been removed and it's a proper gem now. I thought it was Puppet 4.6, but I see puppetlabs/puppet@429b8bd was only in 6.0.0. Still, that's new enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants