fix for issue #297, adding the path for the ldap auth plugin on CentOS 7 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
reviewed
Oct 18, 2018
manifests/params.pp
Outdated
| @@ -30,7 +30,7 @@ | |||
| case $facts['os']['release']['major'] { | |||
| '7': { | |||
| $additional_packages = ['easy-rsa'] | |||
There was a problem hiding this comment.
Should this now also be $additional_packages = ['easy-rsa','openvpn-auth-ldap'] for EL7 as well as EL6?
(If these parameters are now the same on EL6 and EL7, they can also be moved out of this case statement).
There was a problem hiding this comment.
Did EL7 packages become available some time after #215 ?
There was a problem hiding this comment.
It looks like the openvpn-auth-ldap package is now available in the repo for EL7. Will amend the PR.
alexjfisher
requested changes
Oct 18, 2018
manifests/params.pp
Outdated
| @@ -30,7 +30,7 @@ | |||
| case $facts['os']['release']['major'] { | |||
| '7': { | |||
| $additional_packages = ['easy-rsa'] | |||
There was a problem hiding this comment.
Did EL7 packages become available some time after #215 ?
|
Looks related with issue #172 |
|
openvpn-auth-ldap is definately available in epel 7 these days. No idea since when though. |
…lock, as EL7 are now the same as EL6.
Dan33l
requested changes
Oct 29, 2018
|
Oups ? why closed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
A fix for the malformed config file on CentOS 7 when using the LDAP auth plugin.
This Pull Request (PR) fixes the following issues
Fixes #297