-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature / Help Request] Sharing animation sampler input #195
Comments
Hmm... you're right that the time channel accessors could be reused across multiple animations, but it's a double edge sword, because if you want to edit one of the animations afterwards, you could inadvertently edit -all animations- But it's true that glTF is not an editable format, but a final format, so it makes sense to optimize it in that way. I guess I could add something that, when writing the glTF to disk, to look for equivalent accessors and "squeeze" them. I could look into it, but I don't know when I'll have time to it; I have some other gltf tasks on queue... so I'll leave this issue open. |
That sounds great, or I could help to make a pr. Here are some general ideas to achieve this:
There are of course other ideas, maybe you can choose one and then I can help or we can further discuss. (Since I need this function asap, I would like to help, of course) |
First thx for your excellent work!
I would have a request: since gltf itself supports the sampler input sharing, like if I have an assembly, each part will move along the animation with same time frames (0s, 0.1s, 0.2s...) within one accessor. What would be great is to assign the output to each time frame and share the same time line of the entire animation. Thus we could reduce the file size for models with complex animations.
I could not find such an API in your package, or actually the logic may not support this function. (since CurveBuilder has its own key-value pairs).
Again it would be great if you can tell me where do I find the api for this or if you consider to apply this. But it's no big deal, the current version works also fun.
The text was updated successfully, but these errors were encountered: