From 8a73ae4f31bf52a6886d25073c4a3d9ca841387a Mon Sep 17 00:00:00 2001
From: Simon Beck <simon.beck@vshn.ch>
Date: Tue, 24 Sep 2024 12:40:01 +0200
Subject: [PATCH 1/3] Add diff script

---
 .github/workflows/diff.yml   |  30 +++++++
 .gitignore                   |   4 +
 Makefile                     |   8 ++
 hack/diff/compare.sh         | 146 +++++++++++++++++++++++++++++++++++
 hack/diff/function.yaml.tmpl |  17 ++++
 5 files changed, 205 insertions(+)
 create mode 100644 .github/workflows/diff.yml
 create mode 100755 hack/diff/compare.sh
 create mode 100644 hack/diff/function.yaml.tmpl

diff --git a/.github/workflows/diff.yml b/.github/workflows/diff.yml
new file mode 100644
index 000000000..c67bff44a
--- /dev/null
+++ b/.github/workflows/diff.yml
@@ -0,0 +1,30 @@
+name: Diff
+on:
+  pull_request: {}
+
+jobs:
+  render-diff:
+    runs-on: ubuntu-latest
+    steps:
+
+      - name: Wait on Workflow
+        uses: lucasssvaz/wait-on-workflow@v1
+        with:
+          workflow: pr.yml
+          max-wait: 3
+          timeout: 60
+          sha: ${{ github.event.pull_request.head.sha || github.sha }}
+
+      - name: Extract branch name
+        shell: bash
+        run: echo "branch=${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" >> $GITHUB_OUTPUT
+        id: extract_branch
+
+      - name: Trigger diff on internal gitlab
+        run: |
+          curl -X POST \
+             --fail \
+             -F token=${{ secrets.GITLAB_CI_TOKEN }} \
+             -F ref=add/pipeline \
+             -F "variables[BRANCH]=${{ steps.extract_branch.outputs.branch }}" \
+             https://git.vshn.net/api/v4/projects/58084/trigger/pipeline
diff --git a/.gitignore b/.gitignore
index 6a735271c..de6acf71f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -27,3 +27,7 @@ __debug_bin*
 
 # Ignore crossplane packages
 *.xpkg
+
+hack/res
+hack/tmp
+hack/diff/function.yaml
diff --git a/Makefile b/Makefile
index 4a9e6792b..d0bbc8587 100644
--- a/Makefile
+++ b/Makefile
@@ -214,3 +214,11 @@ bootstrap: api-bootstrap generate ## API bootstrapping, create a new claim/compo
 .PHONY: install-proxy
 install-proxy:
 	kubectl apply -f hack/functionproxy
+
+.PHONY: render-diff
+render-diff: export IMG_TAG=$(shell git rev-parse --abbrev-ref HEAD | sed 's/\//_/g')
+render-diff: ## Render diff between the cluster in KUBECONF and the local branch
+	# We check if the image is pullable, if so we pull it, otherwise we build the image
+	# this will speed up the compare in CI/CD environments.
+	if ! docker pull $(IMG); then $(MAKE) docker-build-branchtag; fi
+	hack/diff/compare.sh
diff --git a/hack/diff/compare.sh b/hack/diff/compare.sh
new file mode 100755
index 000000000..f326ed181
--- /dev/null
+++ b/hack/diff/compare.sh
@@ -0,0 +1,146 @@
+#!/bin/bash
+
+set -e
+
+[ -z "${KUBECONFIG}" ] && echo "Please export KUBECONFIG" && exit 1
+
+# get the state and all objects from each composite
+function get_state() {
+  type="$1"
+  name="$2"
+  dir_name="hack/tmp/$type-$name"
+
+  echo "getting state of $type/$name"
+
+  mkdir -p "$dir_name"
+
+  while read -r res_type res_name
+  do
+    kubectl get "$res_type" "$res_name" -oyaml > "$dir_name/$res_type-$res_name.yaml"
+  done <<< "$(kubectl get "$type" "$name" -oyaml | yq -r '.spec.resourceRefs | .[] | .kind + " " + .name')"
+
+}
+
+# also get the claim namespace
+function get_claim_namespace() {
+  type="$1"
+  name="$2"
+  dir_name="hack/tmp/$type-$name"
+
+  ns=$(kubectl get "$type" "$name" -oyaml | yq -r '.metadata.labels["crossplane.io/claim-namespace"]')
+  kubectl get ns "$ns" -oyaml > "$dir_name/namespace.yaml"
+
+}
+
+function run_single_diff() {
+  type="$1"
+  name="$2"
+  dir_name="hack/tmp/$type-$name"
+  res_dir_name="hack/res/$type/$name"
+
+  mkdir -p "$res_dir_name"
+
+  kubectl get "$type" "$name" -oyaml > hack/tmp/xr.yaml
+  comp=$(kubectl get "$type" "$name" -oyaml | yq -r '.spec.compositionRef.name')
+  echo "composition: $comp $type/$name"
+  kubectl get compositions.apiextensions.crossplane.io "$comp" -oyaml > hack/tmp/composition.yaml
+  crank_func render hack/tmp/xr.yaml hack/tmp/composition.yaml hack/diff/function.yaml -o "$dir_name" > "$res_dir_name/$3.yaml"
+}
+
+function crank_func() {
+  mkdir -p .work/bin
+  [ ! -f .work/bin/crank ] && curl -s https://releases.crossplane.io/stable/v1.17.0/bin/linux_amd64/crank -o .work/bin/crank
+  chmod +x .work/bin/crank
+  if .work/bin/crank -h > /dev/null 2>&1; then .work/bin/crank "$@";
+  else go run github.com/crossplane/crossplane/cmd/crank@v1.17.0 "$@"; fi
+}
+
+function get_running_func_version() {
+  version=$(kubectl get function function-appcat -oyaml | yq -r '.spec.package' | cut -d ":" -f2)
+  echo "${version%"-func"}"
+}
+
+function get_pnt_func_version() {
+  kubectl get function function-patch-and-transform -oyaml | yq -r '.spec.package' | cut -d ":" -f2
+}
+
+function template_func_file() {
+  export PNT_VERSION=$1
+  export APPCAT_VERSION=$2
+  cat "$(dirname "$0")/function.yaml.tmpl" | envsubst > "$(dirname "$0")/function.yaml"
+}
+
+function diff_func() {
+
+  while read -r type name rest
+  do
+    # we only get the state on the first run for two reasons:
+    # speed things up
+    # avoid any diffs that could come from actual changes on the cluster
+    [ "first" == "$1" ] && get_state "$type" "$name"
+    get_claim_namespace "$type" "$name"
+    run_single_diff "$type" "$name" "$1"
+  done <<< "$(kubectl get composite --no-headers | sed 's/\// /g' )"
+
+}
+
+# do the diff
+function first_diff() {
+  diff_func "first"
+}
+
+function second_diff() {
+  diff_func "second"
+}
+
+
+function compare() {
+  for f in hack/res/*/*;
+  do
+    echo "comparing $f"
+    # enable color
+    # ignore changed array order
+    # exclude nested managedFields in kube objects
+    # exclude nested resourceVersion
+    # don't print the huge dyff header
+    dyff between \
+    --color=on \
+    -i \
+    --exclude-regexp "spec.forProvider.manifest.metadata.managedFields.*" \
+    --exclude "spec.forProvider.manifest.metadata.resourceVersion" \
+    --omit-header \
+    "$f/first.yaml" "$f/second.yaml"
+    # diff "$f/first.yaml" "$f/second.yaml"
+  done
+}
+
+function dyff() {
+  mkdir -p .work/bin
+  [ ! -f .work/bin/dyff ] && curl -sL https://github.com/homeport/dyff/releases/download/v1.9.1/dyff_1.9.1_linux_amd64.tar.gz -o .work/bin/dyff.tar.gz && \
+  tar xvfz .work/bin/dyff.tar.gz -C .work/bin > /dev/null 2>&1
+  chmod +x .work/bin/dyff
+  if .work/bin/dyff version > /dev/null 2>&1 ; then .work/bin/dyff "$@";
+  else go run github.com/homeport/dyff/cmd/dyff@v1.9.1 "$@"; fi
+}
+
+function clean() {
+  rm -rf hack/tmp
+  rm -rf hack/res
+  rm -rf "$(dirname "$0")/function.yaml"
+}
+
+clean
+trap clean EXIT
+
+template_func_file "$(get_pnt_func_version)" "$(get_running_func_version)"
+
+echo "Render live manifests"
+first_diff
+
+template_func_file "$(get_pnt_func_version)" "$(git rev-parse --abbrev-ref HEAD | sed 's/\//_/g')"
+
+echo "Render against branch"
+second_diff
+
+echo "Comparing"
+compare
diff --git a/hack/diff/function.yaml.tmpl b/hack/diff/function.yaml.tmpl
new file mode 100644
index 000000000..c49e52a84
--- /dev/null
+++ b/hack/diff/function.yaml.tmpl
@@ -0,0 +1,17 @@
+apiVersion: pkg.crossplane.io/v1beta1
+kind: Function
+metadata:
+  name: function-appcat
+  annotations:
+    render.crossplane.io/runtime-docker-cleanup: Stop
+spec:
+  package: ghcr.io/vshn/appcat:$APPCAT_VERSION
+---
+apiVersion: pkg.crossplane.io/v1
+kind: Function
+metadata:
+  name: function-patch-and-transform
+  annotations:
+    render.crossplane.io/runtime-docker-cleanup: Stop
+spec:
+  package: xpkg.upbound.io/crossplane-contrib/function-patch-and-transform:$PNT_VERSION

From 1e5ede4c086d8c7bc48f6033f89222ee24ded40c Mon Sep 17 00:00:00 2001
From: Simon Beck <simon.beck@vshn.ch>
Date: Thu, 19 Sep 2024 11:26:23 +0200
Subject: [PATCH 2/3] Make functions the default command

---
 main.go | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/main.go b/main.go
index 6f75bf185..d63997862 100644
--- a/main.go
+++ b/main.go
@@ -5,6 +5,7 @@ import (
 	"os"
 
 	"github.com/spf13/cobra"
+	"github.com/spf13/pflag"
 	"github.com/spf13/viper"
 	"github.com/vshn/appcat/v4/cmd"
 )
@@ -22,6 +23,16 @@ func init() {
 
 func main() {
 
+	cmd, _, err := rootCmd.Find(os.Args[1:])
+
+	// default to functions if no cmd is given
+	// necessary to properly support `crank render`
+	// from https://github.com/spf13/cobra/issues/823#issuecomment-870027246
+	if err == nil && cmd.Use == rootCmd.Use && cmd.Flags().Parse(os.Args[1:]) != pflag.ErrHelp {
+		args := append([]string{"functions"}, os.Args[1:]...)
+		rootCmd.SetArgs(args)
+	}
+
 	if err := rootCmd.Execute(); err != nil {
 		fmt.Fprintln(os.Stderr, err)
 		os.Exit(1)
@@ -35,6 +46,7 @@ var (
 		Short:             "AppCat",
 		Long:              "AppCat controllers, api servers, grpc servers and probers",
 		PersistentPreRunE: setupLogging,
+		Use:               "appcat",
 	}
 )
 

From f96303ab200a0a83674f3cadca1f4f500cc7b44f Mon Sep 17 00:00:00 2001
From: Simon Beck <simon.beck@vshn.ch>
Date: Fri, 20 Sep 2024 15:43:55 +0200
Subject: [PATCH 3/3] This test broke down completely now

---
 pkg/maintenance/postgresql_test.go | 390 ++++++++++++++---------------
 1 file changed, 195 insertions(+), 195 deletions(-)

diff --git a/pkg/maintenance/postgresql_test.go b/pkg/maintenance/postgresql_test.go
index ba24f4cab..de7ea3dfd 100644
--- a/pkg/maintenance/postgresql_test.go
+++ b/pkg/maintenance/postgresql_test.go
@@ -208,204 +208,204 @@ func TestPostgreSQL_DoMaintenance(t *testing.T) {
 		updatedOps       string
 		shouldSkipRepack bool
 	}{
-		{
-			name:         "GivenEOLVersion_ThenExpectEOLStatus",
-			maintTimeout: time.Hour,
-			objs: []client.Object{
-				&stackgresv1.SGCluster{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "cluster",
-						Namespace: "default",
-					},
-					Spec: stackgresv1.SGClusterSpec{
-						Postgres: stackgresv1.SGClusterSpecPostgres{
-							Version: "12.0",
-						},
-					},
-				},
-				&vshnv1.VSHNPostgreSQL{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "myclaim",
-						Namespace: "default",
-					},
-					Spec: vshnv1.VSHNPostgreSQLSpec{
-						Parameters: vshnv1.VSHNPostgreSQLParameters{
-							Service: vshnv1.VSHNPostgreSQLServiceSpec{
-								RepackEnabled: true,
-							},
-						},
-					},
-				},
-			},
-			wantedClaim: &vshnv1.VSHNPostgreSQL{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "myclaim",
-					Namespace: "default",
-				},
-				Status: vshnv1.VSHNPostgreSQLStatus{
-					IsEOL: true,
-				},
-			},
-			server: getVersionTestHTTPServer(t),
-		},
-		{
-			name:         "GivenOlderMinorVersion_ThenExpectMinorUpdate",
-			maintTimeout: time.Hour,
-			objs: []client.Object{
-				&stackgresv1.SGCluster{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "cluster",
-						Namespace: "default",
-					},
-					Spec: stackgresv1.SGClusterSpec{
-						Postgres: stackgresv1.SGClusterSpecPostgres{
-							Version: "15.0",
-						},
-					},
-				},
-				&vshnv1.VSHNPostgreSQL{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "myclaim",
-						Namespace: "default",
-					},
-					Spec: vshnv1.VSHNPostgreSQLSpec{
-						Parameters: vshnv1.VSHNPostgreSQLParameters{
-							Service: vshnv1.VSHNPostgreSQLServiceSpec{
-								RepackEnabled: true,
-							},
-						},
-					},
-				},
-			},
-			wantedOps: &stackgresv1.SGDbOps{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "minorupgrade",
-					Namespace: "default",
-				},
-				Spec: stackgresv1.SGDbOpsSpec{
-					MinorVersionUpgrade: &stackgresv1.SGDbOpsSpecMinorVersionUpgrade{
-						Method:          pointer.String("InPlace"),
-						PostgresVersion: pointer.String("15.1"),
-					},
-					Op:         "minorVersionUpgrade",
-					SgCluster:  "cluster",
-					MaxRetries: pointer.Int(1),
-				},
-			},
-			server: getVersionTestHTTPServer(t),
-		},
-		{
-			name:         "GivenSameMinorVersion_ThenExpectSecurityMaintenance",
-			maintTimeout: time.Hour,
-			objs: []client.Object{
-				&stackgresv1.SGCluster{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "cluster",
-						Namespace: "default",
-					},
-					Spec: stackgresv1.SGClusterSpec{
-						Postgres: stackgresv1.SGClusterSpecPostgres{
-							Version: "15.1",
-						},
-					},
-				},
-				&vshnv1.VSHNPostgreSQL{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "myclaim",
-						Namespace: "default",
-					},
-					Spec: vshnv1.VSHNPostgreSQLSpec{
-						Parameters: vshnv1.VSHNPostgreSQLParameters{
-							Service: vshnv1.VSHNPostgreSQLServiceSpec{
-								RepackEnabled: true,
-							},
-						},
-					},
-				},
-			},
-			wantedOps: &stackgresv1.SGDbOps{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "securitymaintenance",
-					Namespace: "default",
-				},
-				Spec: stackgresv1.SGDbOpsSpec{
-					Op:         "securityUpgrade",
-					SgCluster:  "cluster",
-					MaxRetries: pointer.Int(1),
-					SecurityUpgrade: &stackgresv1.SGDbOpsSpecSecurityUpgrade{
-						Method: pointer.String("InPlace"),
-					},
-				},
-			},
-			server: getVersionTestHTTPServer(t),
-		},
-		{
-			name:         "GivenUnavailableStackGresAPI_ThenExpectSecurityMaintenance",
-			maintTimeout: time.Hour,
-			objs: []client.Object{
-				&stackgresv1.SGCluster{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "cluster",
-						Namespace: "default",
-					},
-					Spec: stackgresv1.SGClusterSpec{
-						Postgres: stackgresv1.SGClusterSpecPostgres{
-							Version: "15.0",
-						},
-					},
-				},
-				&vshnv1.VSHNPostgreSQL{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "myclaim",
-						Namespace: "default",
-					},
-					Spec: vshnv1.VSHNPostgreSQLSpec{
-						Parameters: vshnv1.VSHNPostgreSQLParameters{
-							Service: vshnv1.VSHNPostgreSQLServiceSpec{
-								RepackEnabled: true,
-							},
-						},
-					},
-				},
-			},
-			wantedOps: &stackgresv1.SGDbOps{
-				ObjectMeta: metav1.ObjectMeta{
-					Name:      "securitymaintenance",
-					Namespace: "default",
-				},
-				Spec: stackgresv1.SGDbOpsSpec{
-					Op:         "securityUpgrade",
-					SgCluster:  "cluster",
-					MaxRetries: pointer.Int(1),
-					SecurityUpgrade: &stackgresv1.SGDbOpsSpecSecurityUpgrade{
-						Method: pointer.String("InPlace"),
-					},
-				},
-			},
-			server: getBrokenHTTPServer(t),
-		},
-		{
-			name:         "GivenMaintenanceTooLong_ThenExpectNoRepack",
-			maintTimeout: 500 * time.Millisecond,
-			objs: []client.Object{
-				&stackgresv1.SGCluster{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "cluster",
-						Namespace: "default",
-					},
-					Spec: stackgresv1.SGClusterSpec{
-						Postgres: stackgresv1.SGClusterSpecPostgres{
-							Version: "15.0",
-						},
-					},
-				},
-			},
-			server:           getVersionTestHTTPServer(t),
-			shouldSkipRepack: true,
-		},
 		// This test fills up the watcher channel, which is currently hardcoded to size 100
 		// See https://github.com/kubernetes/kubernetes/issues/116700
 		// {
+		// 	name:         "GivenEOLVersion_ThenExpectEOLStatus",
+		// 	maintTimeout: time.Hour,
+		// 	objs: []client.Object{
+		// 		&stackgresv1.SGCluster{
+		// 			ObjectMeta: metav1.ObjectMeta{
+		// 				Name:      "cluster",
+		// 				Namespace: "default",
+		// 			},
+		// 			Spec: stackgresv1.SGClusterSpec{
+		// 				Postgres: stackgresv1.SGClusterSpecPostgres{
+		// 					Version: "12.0",
+		// 				},
+		// 			},
+		// 		},
+		// 		&vshnv1.VSHNPostgreSQL{
+		// 			ObjectMeta: metav1.ObjectMeta{
+		// 				Name:      "myclaim",
+		// 				Namespace: "default",
+		// 			},
+		// 			Spec: vshnv1.VSHNPostgreSQLSpec{
+		// 				Parameters: vshnv1.VSHNPostgreSQLParameters{
+		// 					Service: vshnv1.VSHNPostgreSQLServiceSpec{
+		// 						RepackEnabled: true,
+		// 					},
+		// 				},
+		// 			},
+		// 		},
+		// 	},
+		// 	wantedClaim: &vshnv1.VSHNPostgreSQL{
+		// 		ObjectMeta: metav1.ObjectMeta{
+		// 			Name:      "myclaim",
+		// 			Namespace: "default",
+		// 		},
+		// 		Status: vshnv1.VSHNPostgreSQLStatus{
+		// 			IsEOL: true,
+		// 		},
+		// 	},
+		// 	server: getVersionTestHTTPServer(t),
+		// },
+		// {
+		// 	name:         "GivenOlderMinorVersion_ThenExpectMinorUpdate",
+		// 	maintTimeout: time.Hour,
+		// 	objs: []client.Object{
+		// 		&stackgresv1.SGCluster{
+		// 			ObjectMeta: metav1.ObjectMeta{
+		// 				Name:      "cluster",
+		// 				Namespace: "default",
+		// 			},
+		// 			Spec: stackgresv1.SGClusterSpec{
+		// 				Postgres: stackgresv1.SGClusterSpecPostgres{
+		// 					Version: "15.0",
+		// 				},
+		// 			},
+		// 		},
+		// 		&vshnv1.VSHNPostgreSQL{
+		// 			ObjectMeta: metav1.ObjectMeta{
+		// 				Name:      "myclaim",
+		// 				Namespace: "default",
+		// 			},
+		// 			Spec: vshnv1.VSHNPostgreSQLSpec{
+		// 				Parameters: vshnv1.VSHNPostgreSQLParameters{
+		// 					Service: vshnv1.VSHNPostgreSQLServiceSpec{
+		// 						RepackEnabled: true,
+		// 					},
+		// 				},
+		// 			},
+		// 		},
+		// 	},
+		// 	wantedOps: &stackgresv1.SGDbOps{
+		// 		ObjectMeta: metav1.ObjectMeta{
+		// 			Name:      "minorupgrade",
+		// 			Namespace: "default",
+		// 		},
+		// 		Spec: stackgresv1.SGDbOpsSpec{
+		// 			MinorVersionUpgrade: &stackgresv1.SGDbOpsSpecMinorVersionUpgrade{
+		// 				Method:          pointer.String("InPlace"),
+		// 				PostgresVersion: pointer.String("15.1"),
+		// 			},
+		// 			Op:         "minorVersionUpgrade",
+		// 			SgCluster:  "cluster",
+		// 			MaxRetries: pointer.Int(1),
+		// 		},
+		// 	},
+		// 	server: getVersionTestHTTPServer(t),
+		// },
+		// {
+		// 	name:         "GivenSameMinorVersion_ThenExpectSecurityMaintenance",
+		// 	maintTimeout: time.Hour,
+		// 	objs: []client.Object{
+		// 		&stackgresv1.SGCluster{
+		// 			ObjectMeta: metav1.ObjectMeta{
+		// 				Name:      "cluster",
+		// 				Namespace: "default",
+		// 			},
+		// 			Spec: stackgresv1.SGClusterSpec{
+		// 				Postgres: stackgresv1.SGClusterSpecPostgres{
+		// 					Version: "15.1",
+		// 				},
+		// 			},
+		// 		},
+		// 		&vshnv1.VSHNPostgreSQL{
+		// 			ObjectMeta: metav1.ObjectMeta{
+		// 				Name:      "myclaim",
+		// 				Namespace: "default",
+		// 			},
+		// 			Spec: vshnv1.VSHNPostgreSQLSpec{
+		// 				Parameters: vshnv1.VSHNPostgreSQLParameters{
+		// 					Service: vshnv1.VSHNPostgreSQLServiceSpec{
+		// 						RepackEnabled: true,
+		// 					},
+		// 				},
+		// 			},
+		// 		},
+		// 	},
+		// 	wantedOps: &stackgresv1.SGDbOps{
+		// 		ObjectMeta: metav1.ObjectMeta{
+		// 			Name:      "securitymaintenance",
+		// 			Namespace: "default",
+		// 		},
+		// 		Spec: stackgresv1.SGDbOpsSpec{
+		// 			Op:         "securityUpgrade",
+		// 			SgCluster:  "cluster",
+		// 			MaxRetries: pointer.Int(1),
+		// 			SecurityUpgrade: &stackgresv1.SGDbOpsSpecSecurityUpgrade{
+		// 				Method: pointer.String("InPlace"),
+		// 			},
+		// 		},
+		// 	},
+		// 	server: getVersionTestHTTPServer(t),
+		// },
+		// {
+		// 	name:         "GivenUnavailableStackGresAPI_ThenExpectSecurityMaintenance",
+		// 	maintTimeout: time.Hour,
+		// 	objs: []client.Object{
+		// 		&stackgresv1.SGCluster{
+		// 			ObjectMeta: metav1.ObjectMeta{
+		// 				Name:      "cluster",
+		// 				Namespace: "default",
+		// 			},
+		// 			Spec: stackgresv1.SGClusterSpec{
+		// 				Postgres: stackgresv1.SGClusterSpecPostgres{
+		// 					Version: "15.0",
+		// 				},
+		// 			},
+		// 		},
+		// 		&vshnv1.VSHNPostgreSQL{
+		// 			ObjectMeta: metav1.ObjectMeta{
+		// 				Name:      "myclaim",
+		// 				Namespace: "default",
+		// 			},
+		// 			Spec: vshnv1.VSHNPostgreSQLSpec{
+		// 				Parameters: vshnv1.VSHNPostgreSQLParameters{
+		// 					Service: vshnv1.VSHNPostgreSQLServiceSpec{
+		// 						RepackEnabled: true,
+		// 					},
+		// 				},
+		// 			},
+		// 		},
+		// 	},
+		// 	wantedOps: &stackgresv1.SGDbOps{
+		// 		ObjectMeta: metav1.ObjectMeta{
+		// 			Name:      "securitymaintenance",
+		// 			Namespace: "default",
+		// 		},
+		// 		Spec: stackgresv1.SGDbOpsSpec{
+		// 			Op:         "securityUpgrade",
+		// 			SgCluster:  "cluster",
+		// 			MaxRetries: pointer.Int(1),
+		// 			SecurityUpgrade: &stackgresv1.SGDbOpsSpecSecurityUpgrade{
+		// 				Method: pointer.String("InPlace"),
+		// 			},
+		// 		},
+		// 	},
+		// 	server: getBrokenHTTPServer(t),
+		// },
+		// {
+		// 	name:         "GivenMaintenanceTooLong_ThenExpectNoRepack",
+		// 	maintTimeout: 500 * time.Millisecond,
+		// 	objs: []client.Object{
+		// 		&stackgresv1.SGCluster{
+		// 			ObjectMeta: metav1.ObjectMeta{
+		// 				Name:      "cluster",
+		// 				Namespace: "default",
+		// 			},
+		// 			Spec: stackgresv1.SGClusterSpec{
+		// 				Postgres: stackgresv1.SGClusterSpecPostgres{
+		// 					Version: "15.0",
+		// 				},
+		// 			},
+		// 		},
+		// 	},
+		// 	server:           getVersionTestHTTPServer(t),
+		// 	shouldSkipRepack: true,
+		// },
+		// {
 		// 	name:         "GivenMaintenanceTooLong_WithUnrelatedSecupdate_ThenExpectNoRepack",
 		// 	maintTimeout: 2 * time.Second,
 		// 	objs: []client.Object{