Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch "object has been modified" errors in StatefulSet reconcile loop #18

Open
simu opened this issue Oct 19, 2021 · 0 comments
Open

Catch "object has been modified" errors in StatefulSet reconcile loop #18

simu opened this issue Oct 19, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@simu
Copy link
Member

simu commented Oct 19, 2021

Summary

As a developer/operator of the statefulset-resize-controoler
I want to only see "real" errors logged as ERROR
So that I can identify at a glance whether the operator has issues

Context

Currently the controller regularly logs errors like

2021-10-19T11:01:05.758+0200	ERROR	controller-runtime.manager.controller.statefulset	Reconciler error	{"reconciler group": "apps", "reconciler kind": "StatefulSet", "name": "test", "namespace": "sg-test", "error": "Operation cannot be fulfilled on statefulsets.apps \"test\": the object has been modified; please apply your changes to the latest version and try again"}

However, it's expected that sometimes reconciliation of StatefulSet will need to be retried because the object got modified.

We should catch retry errors instead of just logging them as ERROR in the controller.

Out of Scope

  • Fixing other spurious ERROR logs

Further links

n/a

Acceptance criteria

  • When I run the controller, it doesn't log errors regarding StatefulSets being modified while the controller is reconciling them.
@simu simu added the enhancement New feature or request label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant