Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifier CSS class namespace to selected filter on Filter Navigator of Search Result app #5

Closed
juliomoreira opened this issue Jun 19, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@juliomoreira
Copy link

Expected Behavior

As mentioned in #128 we need to be able to identify which filters are selected and style them accordingly;

Current Behavior

There is no CSS class namespace to distinguish which filters are selected or not.

Possible Solution

Add a modifier CSS class namespace to .filterItem something like .filterItem--selected.

Screenshot

Screenshot from 2019-06-19 17-59-02

@saviomuniz saviomuniz added enhancement New feature or request blocked 😢 labels Jun 23, 2019
@juliomoreira
Copy link
Author

Hi @saviofelixmuniz can you please provide some feedback explaining why it's marked as blocked 😢?

@klzns
Copy link
Contributor

klzns commented Jun 25, 2019

Hi @juliomoreira we are checking on our side. We'll give some feedback in a couple of hours.

@klzns
Copy link
Contributor

klzns commented Jun 25, 2019

We will tackle this next week.

@jgfidelis
Copy link

Closed by: vtex-apps/search-result#197

please take a look at the filterItem--selected class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants