Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the "default" policy be called when setAttributeNode is called with a node from the same realm? #434

Closed
mbrodesser-Igalia opened this issue Feb 12, 2024 · 3 comments

Comments

@mbrodesser-Igalia
Copy link
Collaborator

Example: https://jsfiddle.net/3f2tzusq/2/

Happens currently with Chrome Dev. Presumably it shouldn't.

@koto
Copy link
Member

koto commented Feb 12, 2024

Yes. Why do you think it shouldn't? It's in DOM integration set an attribute algorithm (lines 6488-6490 in the current PR).

@mbrodesser-Igalia
Copy link
Collaborator Author

Yes. Why do you think it shouldn't? It's in DOM integration set an attribute algorithm (lines 6488-6490 in the current PR).

Didn't think this through properly before. https://jsfiddle.net/c1noaysw/1/ made me think it shouldn't. However, since srcdoc is aDOMString, the default policy has to be called.

Perhaps the default policy should be able to distinguish values from the same and a different realm. Would need to think more about that.

@mbrodesser-Igalia
Copy link
Collaborator Author

Will open a new ticket for it if necessary,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants