Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dueling edits #178

Open
TallTed opened this issue Jul 1, 2024 · 2 comments
Open

dueling edits #178

TallTed opened this issue Jul 1, 2024 · 2 comments
Assignees

Comments

@TallTed
Copy link
Member

TallTed commented Jul 1, 2024

If |proofConfig|.|created| is set and if the value is not a

The second if is unnecessary. Even better, replace the later if the with its.

To be explicit, change —
If |proofConfig|.|created| is set and if the value is not a
— to —
If |proofConfig|.|created| is set and its value is not a

There seem to be dueling PRs for this. It was changed earlier today, but now it doesn't appear appears to have been (or was un-changed) un-changed.

If there are different opinions about this phrasing, I would like to get them hammered out, and a final PR made.

@TallTed
Copy link
Member Author

TallTed commented Jul 1, 2024

Also note the parallel line, which must be synced with the above —

https://github.com/w3c/vc-di-bbs-test-suite/blob/46e767307e12482bea5ada24d2f0d16e73bd011f/tests/suites/verify.js#L139C1-L140C1

@aljones15
Copy link
Contributor

interesting, some of @Wind4Greg changes were also regressed #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants