Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List view][filters] Adding a filter causes a bug #109

Open
iadawn opened this issue Nov 30, 2022 · 6 comments
Open

[List view][filters] Adding a filter causes a bug #109

iadawn opened this issue Nov 30, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@iadawn
Copy link
Contributor

iadawn commented Nov 30, 2022

In list view if any of the filters are selected the error 'something went wrong' appears.

@iadawn iadawn added this to the MVP milestone Nov 30, 2022
@SteveALee
Copy link
Contributor

The filter code need reworking to address the new item content

@SteveALee SteveALee self-assigned this Dec 1, 2022
@SteveALee SteveALee added the bug Something isn't working label Dec 1, 2022
@SteveALee
Copy link
Contributor

Yuk - the code is completely wrong. Will need to use similar to wai-course-list. Looks like quite a big job :(

@shawna-slh
Copy link
Contributor

What can we do to get V1 done this week? perhaps comment out the filters for now?

@SteveALee
Copy link
Contributor

Will review 1st and if looks like a big job (there's a lot of javascript in the course list) then I suggest comment out as you say.

They are of limited value TBH and there's no data yet anyway.

@SteveALee
Copy link
Contributor

@shawna-slh After exploring I decide to comment out the filters. Also fixed footer layout (no issue for that)

@shawna-slh
Copy link
Contributor

And I used the filter area to provide information. I think we're good for a while.

We can revisit possible filters later... although I'm thinking the type of tool may be more important... and we're not collecting that info right now anyway.

@shawna-slh shawna-slh modified the milestones: MVP, MVP + 2 Dec 10, 2022
@shawna-slh shawna-slh changed the title [List view] Adding a filter causes a bug [List view] for if we re-implement filters) Adding a filter causes a bug Dec 10, 2022
@shawna-slh shawna-slh changed the title [List view] for if we re-implement filters) Adding a filter causes a bug [List view][filters] Adding a filter causes a bug Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants