Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about Games Per Day stats #845

Open
francislavoie opened this issue Oct 17, 2024 · 0 comments · May be fixed by #846
Open

Questions about Games Per Day stats #845

francislavoie opened this issue Oct 17, 2024 · 0 comments · May be fixed by #846

Comments

@francislavoie
Copy link

francislavoie commented Oct 17, 2024

Obviously Direct Strike has had a huge surge in popularity https://w3champions.com/OverallStatistics/

This brings up these questions:

  • Are DS games counted multiple times due to being 3v3 like the sidebar mentions 2v2/4v4/FFA are? I think it seems to be by looking at https://website-backend.w3champions.com/api/w3c-stats/games-per-day output, the numbers are exactly 1/3 of what appears on the graph. Edit: Yes, answered my own question:

    case EGameMode.GM_DS:
    return 3;

    Maybe the text on the left of the graph can be revised to explain that custom games are also normalized?

    Might be interesting to add a checkbox/switch to disable normalizing (should be possible since normalizing is done clientside it seems)?

  • How is "All" calculated? Is it counted server-side? Is it using a specific list of modes to total up? It's impossible that it's including DS games because DS has even surpassed "All" now 😂 unless it only counts pre-normalized numbers?

    Edit: Answered my own question here, it does total the pre-normalized numbers. Definitely causes it to look strange when one mode's normalized number causes it to be higher than "All"!

  • Is there a reason the graph only shows data from 2 days prior? It seems to have data all the way up to current day. I get that it makes sense to skip today's numbers because it would mean the graph would have a hard dip until the day is over, but shouldn't it be safe to show 1 day prior?

    Edit: Oh, I think I'm being misled because the dates displayed are using the local time, which since the timestamps use UTC midnight and I'm on a negative offset timezone (Canada -4:00) means that all the displayed dates are off by one. date-fns's parseJSON function returns local date, but I think it should be changed to then map it back to UTC. Apparently that can be done with date-fns v4 (released last month) which adds a new option to parseJSON like this: parseJSON(date, { in: utc }) (needs import { utc } from "@date-fns/utc";) which makes sure the returned date is in UTC. Should fix that issue.

@francislavoie francislavoie linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant