Potential issue with sorting

[lb-]

I just started to resolve wagtail/wagtail#10719 and have realised that our sorting rules could be causing some issues.

When I run the stylelint formatter / fixer on the Wagtail codebase I see that it's moving all our @include mixins to the top of the selector block.

stylelint-config-wagtail/index.js

Lines 36 to 43 in b5986bb

	// Mixins should always be first in declarations
	'order/order': [
	{
	name: 'include',
	type: 'at-rule',
	},
	'declarations',
	],

From my understanding, this will actually cause a few problems where the styles will not be overridden at breakpoints.

Context of this change.

• Enforce declarations order with stylelint #14
• Enforce order for mixin #17

I know I merged this in but just wondering if there are some nuances for how mixins can be used that we should be allowing.

[lb-]

Maybe a more suitable rule could be

    'order/order': [
      'custom-properties',
      'dollar-variables',
      'declarations',
      'rules',
    ],

This ignores at-rules and at-variables - allowing them to be in any order but will make sure there is some predictable order in the blocks.

https://github.com/hudochenkov/stylelint-order/blob/master/rules/order/README.md

Another idea could be to make @apply (tailwind) appear first but then either allow other at-rules to appear anywhere.

[thibaudcolas]

Indeed! This is the configuration from Torchbox for reference:

        'order/order': [
            'dollar-variables',
            'custom-properties',
            // @-rules that have no nesting.
            { type: 'at-rule', hasBlock: false },
            'declarations',
        ],

[anshikavashistha]

Kindly assign this to me .I want to work on this issue

[lb-]

This might not be a good contribution issue @anshikavashistha but thanks for your interest.

I'm still waiting on feedback for a related PR I to Wagtail that will impact the direction on this issue.

wagtail/wagtail#11151

Additionally, it's possible these rules will not work as is for Wagtail core and more investigation will be needed.

[anshikavashistha]

okay sure @lb-
Definitely I understand

[lb-]

PR up #39