From ba7b44fc0d8dacc27fac847c0be745ff303b18b2 Mon Sep 17 00:00:00 2001 From: danisharora099 Date: Wed, 24 Jul 2024 20:58:31 +0530 Subject: [PATCH] chore: increase timeout for failing tests in CI tests pass locally without an increased timeout, but fail in CI --- packages/core/src/lib/health_manager.ts | 1 - .../tests/health-manager/protocols.spec.ts | 32 +++---------------- 2 files changed, 5 insertions(+), 28 deletions(-) diff --git a/packages/core/src/lib/health_manager.ts b/packages/core/src/lib/health_manager.ts index 215378d25c..12c406a977 100644 --- a/packages/core/src/lib/health_manager.ts +++ b/packages/core/src/lib/health_manager.ts @@ -53,7 +53,6 @@ class HealthManager implements IHealthManager { } private updateOverallHealth(): void { - //TODO: blocked for Store by https://github.com/waku-org/js-waku/pull/2019 const relevantProtocols = [Protocols.LightPush, Protocols.Filter]; const statuses = relevantProtocols.map( (p) => this.getProtocolStatus(p)?.status diff --git a/packages/tests/tests/health-manager/protocols.spec.ts b/packages/tests/tests/health-manager/protocols.spec.ts index 3c90f9e4fa..965753f420 100644 --- a/packages/tests/tests/health-manager/protocols.spec.ts +++ b/packages/tests/tests/health-manager/protocols.spec.ts @@ -18,6 +18,8 @@ import { const NUM_NODES = [0, 1, 2, 3]; describe("Health Manager", function () { + this.timeout(10_000); + let waku: LightNode; let serviceNodes: ServiceNodesFleet; @@ -26,8 +28,11 @@ describe("Health Manager", function () { }); describe("Should update the health status for protocols", () => { + this.timeout(10_000); + NUM_NODES.map((num) => { it(`LightPush with ${num} connections`, async function () { + this.timeout(10_000); [serviceNodes, waku] = await runMultipleNodes( this.ctx, TestShardInfo, @@ -75,33 +80,6 @@ describe("Health Manager", function () { expect(health).to.not.equal(undefined); } - if (num === 0) { - expect(health?.status).to.equal(HealthStatus.Unhealthy); - } else if (num < 2) { - expect(health?.status).to.equal(HealthStatus.MinimallyHealthy); - } else if (num >= 2) { - expect(health?.status).to.equal(HealthStatus.SufficientlyHealthy); - } else { - throw new Error("Invalid number of connections"); - } - }); - //TODO: blocked by https://github.com/waku-org/js-waku/pull/2019 - it.skip(`Store with ${num} connections`, async function () { - [serviceNodes, waku] = await runMultipleNodes( - this.ctx, - TestShardInfo, - undefined, - undefined, - num - ); - - await waku.store.queryWithPromiseCallback([TestDecoder], () => {}); - - const health = waku.health.getProtocolStatus(Protocols.Store); - if (!health) { - expect(health).to.not.equal(undefined); - } - if (num === 0) { expect(health?.status).to.equal(HealthStatus.Unhealthy); } else if (num < 2) {