bug: flaky peer-exchange compliance test

[danisharora099]

This is a bug report

Problem

The peer-exchange compliance test within js-waku has been inconsistent and flaky on its runs:
it was seen to be flakily passing/failing based on local/CI envs without any reproducible/deterministic way.
Recently during some deps upgrade, this flaky test started to consistently fail in the CI while inconsistently passing in the local env.
Certain attempts like #1468 were made to resolve this.

Proposed Solutions

To be figured out

Notes

Failing peer-exchange compliance test might be related to libp2p/js-libp2p#1846

investigation led to a conclusion that peer:update/peer:identify might not be get triggered within the CI
(#1472 (comment))

• Might be related to test: Investigate inconsistent webRTC Interop Tests  libp2p/js-libp2p#1846 (test: Investigate inconsistent webRTC Interop Tests  libp2p/js-libp2p#1846 (comment))

[danisharora099]

Solved with #1478

But will keep this issue open to discuss:

we have added a simple timeout to the dial which waits for the discovery class to have initialised; while this might work, there are theoretically still chances for race conditions

[weboko]

Next steps:

• do profiling and try to get it happen locally;
• check logs step by step

[danisharora099]

we've done a few improvements to remove flakiness like retries, and the said issue has not been reproduced since #1478 was merged.