-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Missing host permission for the tab" when trying to bag a PDF in firefox #386
Comments
It's because Firefox uses it's own internal viewer. You should be able to add it to wallabag it through a right click on the document then |
Similar issue when trying to save a PDF firefox is displaying using file:// from my hard drive. Trying to use the toolbar icon crashes in popup.js line 610:
because the result of exec is null. tab.url is "file:///home/jakkarth/Downloads/foo.pdf", so there's no domain to collect. Also the / after ^ should be escaped I think. User behavior is same as the original case, just says "loading api" forever. When trying to do it through the context menu, it winds its way through to isServicePage on background.js:570, which returns true, so the action fails without any indication to the user that something has gone wrong. I can see why using the URL here would fail (toolbar case), and I think the fix @Simounet mentioned is a reasonable workaround for that case. However, I don't see any reason we should fail to save from the context menu here. file:// isn't a "service page" in the sense that moz-extension:// or about:debugging would be. The contents seems reasonable to save, and should be available the same way that any other viewer'd pdf would be. |
On further examination, the context menu option is still just sending the URL, rather than getting the dom contents from the browser, as far as I can tell. Using content_scripts doesn't work because of the pdf viewer. And no host permissions in the context menu means the executeScript approach won't work. It may just not be possible. |
Yes, at the moment, we can't send PDF content from the browser. Adding from right clicking on the document send the URL. If you've already downloaded the document (having |
I've got a PDF open in a tab in Firefox. You can open it too: https://repository.ubn.ru.nl/bitstream/handle/2066/239928/239928.pdf When I click the wallabagger icon in my tool bar like usual, it opens its little window, and says "Loading wallabag API" forever. When I look in the extension's console, I see this:
It never shows up in wallabag. What else can I provide to help diagnose this issue?
The text was updated successfully, but these errors were encountered: