Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger crashing because log entries are sent out of order #2

Open
norpan opened this issue Oct 22, 2020 · 0 comments
Open

logger crashing because log entries are sent out of order #2

norpan opened this issue Oct 22, 2020 · 0 comments

Comments

@norpan
Copy link

norpan commented Oct 22, 2020

I sometimes get messages out of order even if they are sorted within a batch. This seems to be because the last message of the previous batch is later than the first message of the next batch.

I solved this by just ignoring the error as it's better for me to have the message dropped than logging crashing.

But I'm thinking about how to fix this. Perhaps keep a rolling buffer and only send half of it each time, so that new entries have a chance of being "sorted in"?

My patch is at norpan@0570780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant