-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add shared configs between components / capability #401
Comments
Thanks for the issue @jamesstocktonj1! So @brooksmtownsend and I had some conversations in person about this before. So you currently can use existing configuration items in a wadm manifest and share those between manifests using exactly what you have above (just specifying the name). However, that means the config has to be created out of band (and before) the wadm manifest is deployed. So you can work around this right now, but it isn't ideal. The real solution feels like it would be similar to #277 except for config objects. I think a new Also, going to move this to the wadm repo since it is wadm releated |
Hi Thomas, thanks for moving to the right repo. I hadn't seen that proposal of sharing manifests and I don't see why a Perhaps a scope value could be assigned to the config to make it crystal clear where it should be visible:
I know that #277 is currently in progress but thought I'd propose this just to stir things up. |
I'll have to think about that some more. I definitely think a top level config type could be worth it and would automatically be "global." We could keep other config under the link as well and that would be a "local" scope |
I really like the idea of having configuration be "global" in the manifest sense, e.g. you can define the configuration in the manifest and then refer to it from multiple components/providers/links from within that same manifest 😄 I think it could get a little difficult and fall under the scope of #277 if we wanted to share the configuration between manifests, but I see that being a v2 of this same feature 😄 As for right now, a new |
Affected project(s)
Is your feature request related to a problem? Please describe.
I would like the ability to be able to share configurations between many components and/or capabilities. This can be useful for a range of situations such as having vaguely related services which need to be configured with the same parameters. One such example could be when you have an event producer and an event consumer that need to be configured to communicate on the same topic.
Describe the solution you'd like
One solution could be a new
config
type as seen in this example config:By adding
- name: my-global-config
to the component config this allows both of the components to be configured with the valuetopic: my-topic
.Describe alternatives you've considered
With this solution we could also allow a kind of "overriding" of config values such as the following:
This could be a possible solution to avoid overwriting the
my-global-config
on deployment. But this may make things complicated when it comes to subscribing to config changes.Additional context
No response
The text was updated successfully, but these errors were encountered: