[BUG] Infinite reconciliation loop when overlapping rules exist

[jamesstocktonj1]

Description

Consider a scenario with 4 wasmcloud instances with the following labels:

• node 1 - region=us-east-1, cloud=real
• node 2 - region=us-east-2, cloud=real
• node 3 - region=us-west-1, cloud=real
• node 4 - region=us-west-2, cloud=real

And the following spreadscale properties for a component:

type: spreadscaler
properties:
  instances: 12
  spread:
    - name: eastcoast
      requirements:
        region: us-east-1
      weight: 25
    - name: westcoast
      requirements:
        region: us-west-1
      weight: 25
    - name: realcloud
      requirements:
        cloud: real
      weight: 50

Problem

At first, wadm deploys 3 instances to node 1 and 3 instances to node 3. This satisfies the requirements eastcoast and westcoast but it also satisfies the requirement realcloud. Even though all the requirements are satisfied, the deployment is not successful because the total number of components deployed is 6 and not 12. Therefore Wadm continues the reconciliation process.

After this, in order to try and satisfy the number of instances it deploys 6 instances on either node 2 or node 4. This then satisfies the total number of instances but does not satisfy the weighting for realcloud as it is 100% and not 50%.

This cycle continues as wadm attempts to satisfy all conditions for deployment, resulting in a reconciliation loop with no exit.

TLDR

A spreadscaler config may have a set of requirements which cannot fully be satisfied so the deployment status remains as "Reconciling".