Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wadm missing log-level configuration #450

Open
peter-jerry-ye opened this issue Oct 11, 2024 · 1 comment
Open

Wadm missing log-level configuration #450

peter-jerry-ye opened this issue Oct 11, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue is specifically designated as a good issue for Hacktoberfest

Comments

@peter-jerry-ye
Copy link

It would be great if wadm can have a log level configuration just as wasmcloud host so that debug messages can be printed.

Also, the values.yaml in the chart seem to have that configuration at wadm.config.logLevel, which is a bit misleading.

@brooksmtownsend brooksmtownsend added enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue is specifically designated as a good issue for Hacktoberfest labels Oct 11, 2024
@brooksmtownsend
Copy link
Member

brooksmtownsend commented Oct 11, 2024

Ah yep here we've used RUST_LOG as the log level directive, just hooking into the native Rust support. I think it would be more clear to have a log level flag/env var.

Looks like there's a separate issue but related in fixing the helm chart to use the wadm.config.logLevel value as a RUST_LOG environment variable, or the flag once implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue is specifically designated as a good issue for Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants