Refactor <Link /> components from React-Router to Wasp Links #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zjy2024 looking good, thanks for the PR! Just to check, how did you know which Link's to switch to Wasp's Link? The thing is, Wasp's Link works only for the Routes defined in main.wasp file. So for Links leading to those, we want Wasp's Link, and for other Link's it is ok to use react-router one directly. Seems like all the changes you did are good. I wonder how you detected those, did you replace all the Link's, or hunted down those that are Wasp relevant only? Are you sure there are no Link's still left that could have been converted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#181
Description
Fixes #181
Contributor Checklist