Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubocop and clean-up the code base according to its complaints #25

Open
wbreeze opened this issue Jul 18, 2019 · 1 comment
Open
Labels
good first issue Good for newcomers housekeeping Addresses technical issues not visible to users of the application. Behind the scenes work.

Comments

@wbreeze
Copy link
Owner

wbreeze commented Jul 18, 2019

The rubocop (ruby linting) program run against this code base produces over five hundred complaints. It will be a big job, but adding rubocop and addressing the complaints will improve the code base and enable continuous monitoring by rubocop to keep the code base spit spot.

A little bit of rubocop configuration to eliminate complaint that feels overly strict, is okay but keep it to the minimum.

@wbreeze wbreeze added housekeeping Addresses technical issues not visible to users of the application. Behind the scenes work. good first issue Good for newcomers labels Jul 18, 2019
@wbreeze wbreeze changed the title Add rubocop and clean-up the code base according to its complains Add rubocop and clean-up the code base according to its complaints Jul 18, 2019
@wbreeze
Copy link
Owner Author

wbreeze commented Jul 30, 2019

Can add it straight away. No need to fix everything that exists. There's a feature to put exceptions into a configuration type file. Then chip-away at them as they're touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers housekeeping Addresses technical issues not visible to users of the application. Behind the scenes work.
Projects
None yet
Development

No branches or pull requests

1 participant