Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive no-unreachable #104

Open
wcjohnson opened this issue Oct 2, 2018 · 2 comments
Open

False positive no-unreachable #104

wcjohnson opened this issue Oct 2, 2018 · 2 comments
Labels
4.0 bug linter

Comments

@wcjohnson
Copy link
Owner

screen shot 2018-10-01 at 7 49 14 pm

Minimum test case looks like:

match 1:
  | else: throw 2

3

This is a problem with the linter's CodePathAnalyzer, which can't be overridden by plugins. It's seeing the throw and not realizing it's in a separate code path.
@wcjohnson
Copy link
Owner Author

See: eslint/eslint#10823

@wcjohnson
Copy link
Owner Author

Interesting:

https://github.com/helixbass/eslint-plugin-coffee/blob/master/src/patch-code-path-analysis.coffee

@wcjohnson wcjohnson mentioned this issue Oct 5, 2018
Open
wcjohnson added a commit to wcjohnson/lightscript-eslint that referenced this issue Jul 14, 2020
@wcjohnson
fix(linter): Disable no-unreachable in recommended config
97dd5ec 
This doesn't fix the rule, but it speaks to wcjohnson/lightscript#104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 bug linter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wcjohnson