Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESlint usage incompatible with eslint.config.js #788

Open
Tracked by #158
NoiSek opened this issue Apr 24, 2024 · 10 comments
Open
Tracked by #158

ESlint usage incompatible with eslint.config.js #788

NoiSek opened this issue Apr 24, 2024 · 10 comments

Comments

@NoiSek
Copy link

NoiSek commented Apr 24, 2024

This action's default usage of --ext when using the eslint linter prevents the action from running when using the modern eslint.config.js flat file configuration.

This problem seems to have been highlighted by three other parties in #730, #739, and #759 but those issues were not addressed.

If there is no critical reason that this can't be updated, please keep this one open for discussion if possible. I would be happy to PR a fix for this myself if there are no major obstacles or objections.

@rkuykendall
Copy link

I think this may be a fix: #799

I just had it only use ext if the argument is passed in.

I can't tell how to test it or use it on my own repo though.

@rkuykendall
Copy link

I figured out how to use it in my repo but now I can't figure out how to make eslint_extensions optional.

@rkuykendall
Copy link

Also, eslint_extensions defaults to JS, so we may have a problem there. I wonder if using a version check on eslint somehow is a better solution.

@mismith
Copy link

mismith commented Jul 16, 2024

Any luck with this? It would be great to get this released since there's currently no workaround, is there?

@alonapester
Copy link

It seems like in #799 that using version 8.56.0 made it work for me, but 9 still does not work

@0x0wen
Copy link

0x0wen commented Sep 3, 2024

So does that mean this action doesn't support eslint v9? If not, do you guys have any recommendation that does?

@jake-perkins
Copy link

Any traction on this one ? We use this action and would like to support the v9 flows, Seems theres a PR already to add support

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 10, 2024
@Primajin
Copy link

Apparently this got stale and the PR was killed because it also went stale 😢

@edlouth
Copy link

edlouth commented Dec 18, 2024

For now one can use the fork from the PR to get things working

- name: Lint Action
        uses: rkuykendall/lint-action@master
        with:
          auto_fix: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants