Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate settings field for repository URL #57

Open
swissspidy opened this issue Sep 27, 2018 · 6 comments
Open

Use separate settings field for repository URL #57

swissspidy opened this issue Sep 27, 2018 · 6 comments
Labels
[Status] Maybe later Worth reconsidering at some point in the future [Type] Enhancement New functionality

Comments

@swissspidy
Copy link
Collaborator

This way we don't have to guess the repsitory URL based on the "Source file URL" field.

Also, one might want to use Traduttore without having "Source file URL" set.

@swissspidy
Copy link
Collaborator Author

Looking at GlotPress code, this won‘t be feasible without overriding the complete template file I think.

Here‘s another thought I had:

When we receive an incoming webhook for a given project, we store the repository type (gitlab, github, etc.) and perhaps the URL/host as project meta. In theory also the vcs type (git/hg) for Bitbucket repositories.

This way when trying to clone the repository we don‘t have to figure out where it resides, which is of course useful for self-hosted GitLab and things like that.

@swissspidy
Copy link
Collaborator Author

swissspidy commented Oct 29, 2018

Ideally we‘d also have settings fields for the webhook secrets.

@swissspidy
Copy link
Collaborator Author

When we receive an incoming webhook for a given project, we store the repository type (gitlab, github, etc.) and perhaps the URL/host as project meta. In theory also the vcs type (git/hg) for Bitbucket repositories.

That already works now.

Ideally we‘d also have settings fields for the webhook secrets.

-> #80

@swissspidy
Copy link
Collaborator Author

Looking at GlotPress code, this won‘t be feasible without overriding the complete template file I think.

@ocean90 Can you confirm this?

@ocean90
Copy link
Member

ocean90 commented Nov 2, 2018

You mean project-form.php? Yes, there's no filter yet. Maybe worth creating an issue/PR?

@swissspidy
Copy link
Collaborator Author

Opened an issue upstream: GlotPress/GlotPress#969

@swissspidy swissspidy added the [Status] Maybe later Worth reconsidering at some point in the future label Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Maybe later Worth reconsidering at some point in the future [Type] Enhancement New functionality
Projects
None yet
Development

No branches or pull requests

2 participants