Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeouts for promotions: setup default and allow the user to override #138

Open
enekofb opened this issue Jan 3, 2023 · 2 comments
Open

Comments

@enekofb
Copy link
Contributor

enekofb commented Jan 3, 2023

during promotions, for example, pull request promotions, we have operations that might be expensive in terms of time,
for example, cloning a configuration repo would depend on the size of the repo

In order to control this scenario, we would like tohave default timeout for the promotion execution and the ability to of the user to override this value within the pipeline CR

AC

  • define the timeout strategy for pipeline promotions
  • implement providing a default and user-specific override
@LappleApple
Copy link

From @yitsushi: "Right now with all our demo stuff it's happy, but as soon as it hits heavy load it may [have problems] handling long running processes without expected timeout. It can hurt on mono-repos with a lot of changes (I don't know if we shallow clone or full clone, I hope shallow)"

@LappleApple
Copy link

To revisit after Pipelines 2.0 work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants