Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check every key (regardless of compute_from) for discouraged condition #2228

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Check every key (regardless of compute_from) for discouraged condition #2228

wants to merge 8 commits into from

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Nov 13, 2024 •
edited
Loading

Fixes #1894. If compute_from is set, then explicitly check every key's deprecated value.

Right now this is not great—it's quite slow. I need to do some sort of refactoring here to not run computeBaseline on every key twice. It's too late in the day for me to think that through.

@github-actions github-actions bot added the tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings label Nov 13, 2024
@ddbeck ddbeck force-pushed the surface-discouraged-on-compute-from branch from e77a819 to e5e7442 Compare November 13, 2024 16:50
@ddbeck ddbeck marked this pull request as ready for review November 14, 2024 09:04
jamesnw
jamesnw approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ddbeck
Copy link
Collaborator Author

ddbeck commented Nov 14, 2024

OK, then if we're going down this route we have a little bit of work to do. These are the keys currently failing the test:

  • api.FontFaceSet.FontFaceSet
  • api.CanMakePaymentEvent.methodData
  • api.CanMakePaymentEvent.modifiers
  • api.CanMakePaymentEvent.paymentRequestOrigin
  • api.CanMakePaymentEvent.topOrigin
  • api.PaymentManager.instruments
  • api.PaymentRequestEvent.instrumentKey
  • api.PaymentRequest.merchantvalidation_event
  • api.PaymentRequest.shippingAddress
  • api.PaymentRequest.shippingOption
  • api.PaymentRequest.shippingType
  • api.PaymentRequest.shippingaddresschange_event
  • api.PaymentRequest.shippingoptionchange_event
  • css.at-rules.media.prefers-color-scheme.no-preference
  • api.SVGAnimateColorElement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

@jamesnw jamesnw jamesnw approved these changes

Assignees
No one assigned
Labels
tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compute_from suppresses deprecation warnings
3 participants
@ddbeck @jamesnw @Elchi3