Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline status regressions should be more obvious on review #1947

Open
ddbeck opened this issue Oct 11, 2024 · 3 comments
Open

Baseline status regressions should be more obvious on review #1947

ddbeck opened this issue Oct 11, 2024 · 3 comments
Labels
enhancement New feature or request tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings

Comments

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 11, 2024

It'd be nice if PRs that change a feature's Baseline status from high or low to false get more scrutiny. I'm imagining a GitHub Actions workflow that leaves a comment or appends to the PR description when this happens.

I didn't notice that popover regressed when I upgraded BCD in #1797. Discovered via GoogleChrome/webstatus.dev#739

@ddbeck ddbeck added enhancement New feature or request tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings labels Oct 11, 2024
@ddbeck
Copy link
Collaborator Author

ddbeck commented Oct 11, 2024

The calculation is correct with respect to the data, so it's not a bug. But I believe this is the first time that we've moved a recent feature's status backwards solely on a BCD upgrade, which changes many files. Without a little more attention, we might allow an unintended status change to take place (e.g., from a later addition being tagged in BCD).

@jcscottiii
Copy link

Hey @ddbeck!

Thoughts on this one too?

GoogleChrome/webstatus.dev#740

@ddbeck
Copy link
Collaborator Author

ddbeck commented Oct 15, 2024

Thoughts on this one too?

GoogleChrome/webstatus.dev#740

I've updated that issue with more information and a link to my related BCD PR: mdn/browser-compat-data#24720

Also, for anyone else following along with regards to the inciting popover feature. I shared my commentary (see GoogleChrome/webstatus.dev#739 (comment)) with the WebDX chat and—so far—there's agreement that popover's status is correct. I think that one will stand, but explicitly affirming that fact before releasing an update would've been nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tools and infrastructure Project internal tooling, such as linters, GitHub Actions, or repo settings
Projects
None yet
Development

No branches or pull requests

2 participants