Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing MDS types #136

Open
gaizeror opened this issue Sep 1, 2023 · 1 comment
Open

Missing MDS types #136

gaizeror opened this issue Sep 1, 2023 · 1 comment

Comments

@gaizeror
Copy link
Contributor

gaizeror commented Sep 1, 2023

Hey,

I tried to use MDS classes in my typescript project and found out that the types of MDS classes and the static functions in Fido2Lib class are not exported.
Is there a reason for it? is there a types lib can be installed?
I don't mind creating a PR with the missing interfaces, but I think it should either be a requirement for new features or excluded from the project, the partial types is annoying

example:
image
image

Thanks

@gaizeror gaizeror changed the title Typescript support missing MDS types Sep 1, 2023
@gaizeror gaizeror changed the title missing MDS types Missing MDS types Sep 1, 2023
@JamesCullum
Copy link
Member

Thanks for the great suggestion. The library isn't primarily focusing on typescript (as it's been born in a time before , but tries to allow integration with those projects with syntax highlighting.

Generally we're favoring compatibility and features over typescript conformity, so I wouldn't be in favor of blocking good code requests without it.

If we can improve the typescript types without adding other issues, PRs etc are always welcome and we can try to ask contributors to extend the interface accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants