Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] vim-go: Go 1.18 drops support for go get (replaced by go install?) #441

Closed
coolaj86 opened this issue Apr 14, 2022 · 6 comments
Closed

[Bug] vim-go: Go 1.18 drops support for go get (replaced by go install?) #441

coolaj86 opened this issue Apr 14, 2022 · 6 comments
Assignees
@saikmusunuri
Labels
bug Something isn't working first-timers-only good first issue Good for newcomers up-for-grabs

Comments

@coolaj86
Copy link
Member

coolaj86 commented Apr 14, 2022 •
edited
Loading

Originally we used go get because go install wouldn't work with go modules.

Now go get won't work with go modules and go install does.

I think the solution is to replace go get with go install in https://github.com/webinstall/webi-installers/blob/main/vim-go/install.sh

Workaround

webi vim-go

vim main.go
:GoInstallBinaries
@coolaj86 coolaj86 added bug Something isn't working good first issue Good for newcomers first-timers-only up-for-grabs labels Apr 14, 2022
@saikmusunuri
Copy link
Contributor

Hey @coolaj86, can you please assign it to me. I would like to contribute to this. Thanks!

@saikmusunuri
Copy link
Contributor

Hey @coolaj86, any update on this?

@coolaj86
Copy link
Member Author

@saikmusunuri Please do.

@saikmusunuri
Copy link
Contributor

Thanks! I will start working on it very soon.

saikmusunuri added a commit to saikmusunuri/webi-installers that referenced this issue Apr 25, 2022
@saikmusunuri
[Bug] vim-go: Go 1.18 drops support for go get webinstall#441
ddbdea1 
Go 1.18 dropped support for `go get` so as suggested, I have replaced `go get` with `go install`. Please go through it and let me know if any change is required.
@saikmusunuri
Copy link
Contributor

Hey @coolaj86, please review the PR. Thanks!

coolaj86 pushed a commit to saikmusunuri/webi-installers that referenced this issue Aug 8, 2022
@saikmusunuri @coolaj86
fix(go): Go 1.18 drops support for 'go get' webinstall#441
bb27307 
Go 1.18 dropped support for `go get` so as suggested, I have replaced `go get` with `go install`. Please go through it and let me know if any change is required.
coolaj86 pushed a commit to saikmusunuri/webi-installers that referenced this issue Aug 8, 2022
@saikmusunuri @coolaj86
fix(vim-go): Go 1.18 drops support for 'go get' webinstall#441
25b9bbd 
Go 1.18 dropped support for `go get` so as suggested, I have replaced `go get` with `go install`. Please go through it and let me know if any change is required.
@coolaj86
Copy link
Member Author

coolaj86 commented Aug 8, 2022

Closing because this was fixed and merged.

@coolaj86 coolaj86 closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saikmusunuri saikmusunuri

Labels
bug Something isn't working first-timers-only good first issue Good for newcomers up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coolaj86 @saikmusunuri