-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] vim-go: Go 1.18 drops support for go get
(replaced by go install
?)
#441
Labels
Comments
coolaj86
added
bug
Something isn't working
good first issue
Good for newcomers
first-timers-only
up-for-grabs
labels
Apr 14, 2022
Hey @coolaj86, can you please assign it to me. I would like to contribute to this. Thanks! |
Hey @coolaj86, any update on this? |
@saikmusunuri Please do. |
Thanks! I will start working on it very soon. |
saikmusunuri
added a commit
to saikmusunuri/webi-installers
that referenced
this issue
Apr 25, 2022
Go 1.18 dropped support for `go get` so as suggested, I have replaced `go get` with `go install`. Please go through it and let me know if any change is required.
Hey @coolaj86, please review the PR. Thanks! |
coolaj86
pushed a commit
to saikmusunuri/webi-installers
that referenced
this issue
Aug 8, 2022
Go 1.18 dropped support for `go get` so as suggested, I have replaced `go get` with `go install`. Please go through it and let me know if any change is required.
coolaj86
pushed a commit
to saikmusunuri/webi-installers
that referenced
this issue
Aug 8, 2022
Go 1.18 dropped support for `go get` so as suggested, I have replaced `go get` with `go install`. Please go through it and let me know if any change is required.
Closing because this was fixed and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Originally we used
go get
becausego install
wouldn't work with go modules.Now
go get
won't work with go modules andgo install
does.I think the solution is to replace
go get
withgo install
in https://github.com/webinstall/webi-installers/blob/main/vim-go/install.shWorkaround
The text was updated successfully, but these errors were encountered: