-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Manifest V3 #131
Comments
Yes, this is planned, eventually. I've done some tests and mostly it works, since already using a service worker. |
rename chrome.browserAction -> chrome.action include ext/bg.js in sw/main.js (addresses #131)
rename chrome.browserAction -> chrome.action include ext/bg.js in sw/main.js (addresses #131)
rename chrome.browserAction -> chrome.action include ext/bg.js in sw/main.js (addresses #131) move replay root to ./ from ./replay/ dynamically import sw.js from bg.js, use bg.js as service-worker entrypoint ipfs: add Origin header overrides via declarative-net-request rules, also add as permission via brave-ipfs.json rules bump version to 0.10.0
Hi @ikreymer
Will update if we face more issue as I said we are in the process now |
Note the protobuf is consumed from IPFS Utils which uses @ipld/unixfs and there's also an issue for it: |
To clarify, are these errors you're encountering in the extension, or comments from the chrome web store submission process? The MV3 branch does build and run, though haven't tested it as extensively yet, and only in dev builds. Can you put the fork that you're using up on GitHub somewhere, so we can be more clear what you're referring to? |
The errors are in the submission process, will share and let you know ASAP
…On Wed, Sep 13, 2023, 09:43 Ilya Kreymer ***@***.***> wrote:
Hi @ikreymer <https://github.com/ikreymer> We try now to push our
extension to the chrome store and it does require Manifest 3 only (New
extension) Want to share few obstacles we are facing regarding usage of
eval in the code:
To clarify, are these errors you're encountering in the extension, or
comments from the chrome web store submission process?
The MV3 branch does build and run, though haven't tested it as extensively
yet, and only in dev builds.
Can you put the fork that you're using up on GitHub somewhere, so we can
be more clear what you're referring to?
—
Reply to this email directly, view it on GitHub
<#131 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPJPWROLEK6SXHCB5FDJJ3X2FIYZANCNFSM6AAAAAATWXQFQE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
We faced issues with upgrading to Yarn 3.* ,we got only in the production build next error:
I digged it and it seems like error in the yarn3 with the webpack(Tried also upgrading webpack didn't help)
For now I will try to go back to yarn 2 and see if it helps , will update |
This comment was marked as spam.
This comment was marked as spam.
Edit: Hm, this may actually be working with latest @ipld/unixfs |
We finally got it approved but with the changes I mentioned before aka next patches: Not sure if approval for existing extension will be easier than new extensions. I will check with Riki who manages the project if she encountered other issues. |
- the extension is now served from chrome-extension://<id>/index.html instead of chrome-extension://<id>/replay/index.html as the service worker registration is no longer needed. - Added check to uninstall old service worker from ./replay/sw.js as new service worker is served from ./bg.js - sw registration removed (unless in embed mode), now registered automatically - CSP disabling allows for PDF text extraction + ruffle to work as before, and still needed for replay - remove brave IPFS support, regular IPFS support via auto-js-ipfs remains, including custom serialization via ipld/car - dependencies: update to latest awp-sw - embed fixes: fix window size, remove dist files from git, use http-server to serve embed page. Fixes #131
What about switching to manifest V3?
See:
https://developer.chrome.com/docs/extensions/mv3/intro/
As of January 17, 2022 the Chrome Web Store has stopped accepting new Manifest V2 extensions. We strongly recommend migrating your extensions to Manifest V3 as soon as possible; this will become mandatory after Manifest V2 is phased out in 2024.
The text was updated successfully, but these errors were encountered: