Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devex]: Asset Referencing Cleanup #260

Open
Shrinks99 opened this issue Oct 17, 2024 · 0 comments
Open

[Devex]: Asset Referencing Cleanup #260

Shrinks99 opened this issue Oct 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Shrinks99
Copy link
Member

Shrinks99 commented Oct 17, 2024

Left over task from #227 that can be finished now that the app is converted to TypeScript!

from that PR:

  • Does not use the TsconfigPathsPlugin plugin for assets referenced with ~assets like Browsertrix and ReplayWeb.page (because obviously this isn't TypeScript yet!) Would be a nice thing to clean up with the TypeScript conversion later to have the same conventions across all our projects.
  • The main app logo is currently composed of the graphic component returned by ReplayWeb.page which is then assigned a different variable in ArchiveWeb.page with get mainLogo. The text is then appended by ArchiveWeb.page.
    • Because the text and icon are now located in the same file for both apps, this behavior is worth cleaning up once both are up to date and using TypeScript. For now, this returns nothing as the mainLogo value and appends the whole new logo lockup instead of just the text.
    • See https://github.com/webrecorder/replayweb.page/blob/main/src/appmain.ts#L298 for context and details in ReplayWeb.page.
@Shrinks99 Shrinks99 added the enhancement New feature or request label Oct 17, 2024
@Shrinks99 Shrinks99 self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Triage
Development

No branches or pull requests

1 participant