You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Left over task from #227 that can be finished now that the app is converted to TypeScript!
from that PR:
Does not use the TsconfigPathsPlugin plugin for assets referenced with ~assets like Browsertrix and ReplayWeb.page (because obviously this isn't TypeScript yet!) Would be a nice thing to clean up with the TypeScript conversion later to have the same conventions across all our projects.
The main app logo is currently composed of the graphic component returned by ReplayWeb.page which is then assigned a different variable in ArchiveWeb.page with get mainLogo. The text is then appended by ArchiveWeb.page.
Because the text and icon are now located in the same file for both apps, this behavior is worth cleaning up once both are up to date and using TypeScript. For now, this returns nothing as the mainLogo value and appends the whole new logo lockup instead of just the text.
Left over task from #227 that can be finished now that the app is converted to TypeScript!
from that PR:
The text was updated successfully, but these errors were encountered: