New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verifier: don't expose the full S3 path when reporting checksum errors #1089

Open

alexwlchan opened this issue Jul 25, 2019 · 1 comment

Labels

🐛 Bug ✅ Bag verification

Contributor

alexwlchan commented Jul 25, 2019

This is an example error from the verifier:

https://wellcomecollection-storage-staging-ingests.s3.eu-west-1.amazonaws.com/unpacked/alex-testing/2f55a087-b9ab-4fdb-8156-5d177db55d84/b2227683x/fetch.txt: Checksum values do not match! Expected: sha256:ada213f9ed885fafdd2c1faf48c8b3182fafb59e6dae84eeffc045aca90d1435, saw: sha256:aae34cb7e92493c6f71da185132d54905a49dbce8cf349b72c4cb67dc6777ca9

This bit is an internal concern of the storage service and shouldn't be exposed in a user-facing message:

https://wellcomecollection-storage-staging-ingests.s3.eu-west-1.amazonaws.com/unpacked/alex-testing/2f55a087-b9ab-4fdb-8156-5d177db55d84

The text was updated successfully, but these errors were encountered:

alexwlchan transferred this issue from wellcomecollection/platform

alexwlchan added 🐛 Bug ✅ Bag verification labels

Contributor Author

alexwlchan commented Aug 21, 2023

(It's been four years since I wrote this issue, and it's possible it's been fixed since then. I haven't retested.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment