Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think, we probably shouldn't implement RemoveCredential() #12

Open
chiro-hiro opened this issue Jul 3, 2021 · 0 comments
Open

I think, we probably shouldn't implement RemoveCredential() #12

chiro-hiro opened this issue Jul 3, 2021 · 0 comments

Comments

@chiro-hiro
Copy link

Regarding this section https://www.w3.org/TR/did-core/#persistence.

DIDs are designed to be persistent such that a controller need not rely upon a single trusted third party or administrator to maintain their identifiers. In an ideal case, no administrator can take control away from the controller, nor can an administrator prevent their identifiers' use for any particular purpose such as authentication, authorization, and attestation. No third party can act on behalf of a controller to remove or render inoperable an entity's identifier without the controller's consent.

So, I think the revoke process should be tracked.

https://github.com/whalelephant/CertX/blob/main/certX/x/credentials/keeper/credential.go#L88

// RemoveCredential removes a credential from the store
func (k Keeper) RemoveCredential(ctx sdk.Context, id uint64) {
	store := prefix.NewStore(ctx.KVStore(k.storeKey), types.KeyPrefix(types.CredentialKey))
	store.Delete(GetCredentialIDBytes(id))
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant