-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove -webkit-mask-box from the legacy alias name so they stand on their own. #202
Comments
As of today
canIuse mask-border is in fact just mentioning That looks pretty dead to me as an alias for now. @birtles I see you are one of the spec editors. Do you see any progress? @miketaylr Should we move these properties in their own section as there is no real implemented mapping 1-1 to a non-aliased one. |
Sorry, I haven't touched that spec for years. |
I didn't find any breakage on webcompat issues related to On GitHub, CSS are usually already associating the two propoerties with the same value.
|
… of alias As shown in whatwg/compat#202 there is currently no browsers implementing the mask-border-*, which should be the equivalent. They stand on their own and probably for now deserves a test by themselves.
As shown in whatwg/compat#202 there is currently no browsers implementing the mask-border-*, which should be the equivalent. They stand on their own and probably for now deserves a test by themselves.
I think the most important thing is to keep linking to https://drafts.fxtf.org/css-masking/#the-mask-border-source etc, since that's where it's properly specced (even without unprefixed implementations). Whether that is considered a legacy alias, or its own thing - I don't think it matters much. Possibly browsers implement the unprefixed props one day, and then it becomes a legacy alias. Do we move things back? |
yes. |
Sure, that works for me (I'm also fine with doing nothing ^___^). |
* Issue #34493 - Orders alphabetically * Issue #34493 - Adds webkitBackgroundClip to the list of alias This was forgotten when handling whatwg/compat#195 * Issue #34493 - Adds webkitBoxSizing to the list of alias It is correctly defines in browsers and everyone implements it. This was defined initially in whatwg/compat#9 * Issue #34493 - Removes webkitMaskBox* from the list of alias As shown in whatwg/compat#202 there is currently no browsers implementing the mask-border-*, which should be the equivalent. They stand on their own and probably for now deserves a test by themselves. * Issue #34493 - Adds webkitMaskBox* to a unique test As shown in whatwg/compat#202 there is currently no browsers implementing the mask-border-*, which should be the equivalent. They stand on their own and probably for now deserves a test by themselves.
@miketaylr what about if I send a PR to add a comment similar to the one about |
SGTM! |
Strong +1 to this.
Honestly I'm a bit skeptical about how much value there is in this. Even just putting a note saying that this isn't actually an alias in existing implementations seems… kinda sensible? Or maybe we need some new concept for aliasing which isn't aliasing that can also cover things like |
yes.
While in this case, none of the browsers, actually implement the other values. So for now it is really a case of
which is not aliasing. |
Related to our discussion |
…compat spec, a=testonly Automatic update from web-platform-tests Fix #34493 - Adds missing tests for the compat spec (#34520) * Issue #34493 - Orders alphabetically * Issue #34493 - Adds webkitBackgroundClip to the list of alias This was forgotten when handling whatwg/compat#195 * Issue #34493 - Adds webkitBoxSizing to the list of alias It is correctly defines in browsers and everyone implements it. This was defined initially in whatwg/compat#9 * Issue #34493 - Removes webkitMaskBox* from the list of alias As shown in whatwg/compat#202 there is currently no browsers implementing the mask-border-*, which should be the equivalent. They stand on their own and probably for now deserves a test by themselves. * Issue #34493 - Adds webkitMaskBox* to a unique test As shown in whatwg/compat#202 there is currently no browsers implementing the mask-border-*, which should be the equivalent. They stand on their own and probably for now deserves a test by themselves. -- wpt-commits: 53ae4d8624fc8a03548805de428cbc04155d59f7 wpt-pr: 34520
…compat spec, a=testonly Automatic update from web-platform-tests Fix #34493 - Adds missing tests for the compat spec (#34520) * Issue #34493 - Orders alphabetically * Issue #34493 - Adds webkitBackgroundClip to the list of alias This was forgotten when handling whatwg/compat#195 * Issue #34493 - Adds webkitBoxSizing to the list of alias It is correctly defines in browsers and everyone implements it. This was defined initially in whatwg/compat#9 * Issue #34493 - Removes webkitMaskBox* from the list of alias As shown in whatwg/compat#202 there is currently no browsers implementing the mask-border-*, which should be the equivalent. They stand on their own and probably for now deserves a test by themselves. * Issue #34493 - Adds webkitMaskBox* to a unique test As shown in whatwg/compat#202 there is currently no browsers implementing the mask-border-*, which should be the equivalent. They stand on their own and probably for now deserves a test by themselves. -- wpt-commits: 53ae4d8624fc8a03548805de428cbc04155d59f7 wpt-pr: 34520
6 years later no browsers are implementing
mask-border
and variants. We should probably remove-webkit-mask-box
from the legacy alias name, and move them to a section where we say that they need to be supported on their own.Originally posted by @karlcow in #14 (comment)
Maybe a note could be added that the intent is that they would be used/aliased as mask-border, but at this time nobody does, nor even implement
mask-border
.The text was updated successfully, but these errors were encountered: