Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORCIDs provided in Tales should be validated #405

Open
Xarthisius opened this issue Mar 4, 2020 · 2 comments
Open

ORCIDs provided in Tales should be validated #405

Xarthisius opened this issue Mar 4, 2020 · 2 comments

Comments

@Xarthisius
Copy link
Collaborator

Otherwise we get:

Failed to create a deposition. Server returned: 400 Client Error: BAD REQUEST for url: https://sandbox.zenodo.org/api/deposit/depositions { "errors": [ { "field": "metadata.creators.0.orcid", "message": "Not a valid ORCID identifier." } ], "message": "Validation error.", "status": 400 }
@ThomasThelen
Copy link
Member

I was hoping that the ORCID python library would have a method for validating IDs but it looks like they don't. The easiest way would be to just query ORCID with the ID and see check what comes back (time-costly). ORCID also has some information on how they're generated that can probably be reverse engineered to check the ID string.

@ThomasThelen
Copy link
Member

ThomasThelen commented Oct 19, 2020

Linking to #432. By requiring the user to connect their ORCID account we'll have a valid ORCID.

We know that the dataset creator has a valid ORCID because they're signed into Whole Tale. This user can add additional authors, including their ORCID. @Xarthisius do you think that for each author in the metadata, validate the ORCID? Or do you think that having at least one valid ORCID is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants