Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Vue 3 support (via component_vue at least) #915

Open
2 tasks
JovanVeljanoski opened this issue Dec 8, 2024 · 1 comment
Open
2 tasks
Labels
enhancement New feature or request

Comments

@JovanVeljanoski
Copy link
Collaborator

Feature Request

  • The requested feature would break current behaviour
  • I would be interested in opening a PR for this feature

What problem would this feature solve? Please describe.

Solara currently uses vuetifyjs for frontend components, but that is tied to vue 2. That is getting a bit outdated, and vue 3 offers more features/flexibility and more concise syntax.

I understand that migrating entirely to vue 3 is a bit of work, since i guess you need to migrate ipyvuetify, maybe reacton and all sorts of libraries also, before migrating solara.

Describe the solution you'd like

But I am wondering.. if anyone is interested in writing their own vuetify templates via the @solara.component_vue() decorator..
Would it be possible to either:

  • make a new decorator, example @solara.component_vue3() that would be vue 3 compatible
  • update the existing decorator, to have a kwarg that says this is vue 3 file. e.g. @solara.component_vue('./mytemplate.vue', vue3=True)

I wonder if such a thing is possible.. or are we stuck we vue 2 until solara 2.0 or so.. which I assume is still quite far in the future?
Maybe what I am asking is not possible/practical, but voicing it just in case

Documentation, Migration Strategy

Easy to document. If one day solara goes full on vue 3, (which would be a breaking change), then simply remove the "new" decorator or keep it with a deprecation warning.

@JovanVeljanoski JovanVeljanoski added the enhancement New feature or request label Dec 8, 2024
@JovanVeljanoski JovanVeljanoski changed the title Feature Request: Feature Request: Vue 3 support (via component_vue at least) Dec 8, 2024
@maartenbreddels
Copy link
Contributor

See also https://solara.dev/roadmap

Solara 2.0 should be out not too long from now (it's not a lot of breaking changes).

After that, we plan to go for Solara 3.0, ipyvue 3.x, ipyvuetify 3.x which will use vue 3.x and vuetify 3.x.

Note that we already are testing this in our CI:

integration-test-vue3:

OOOPS, while writing this, we discovered #920 , but given that #921 is green, you should be able to do

pip install "ipyvue>=3" "ipyvuetify>=3" --pre  # use vue3 and vuetify3

Not all components are tested, and we are happy to fix, or receive PR's to fix those. Our plan it to be as much as forward and backward compatible as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants