Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Use transactions when executing SQL statements. #6

Open
tmartin opened this issue Jun 28, 2012 · 1 comment
Open

[SQL] Use transactions when executing SQL statements. #6

tmartin opened this issue Jun 28, 2012 · 1 comment

Comments

@tmartin
Copy link
Member

tmartin commented Jun 28, 2012

For now, SQL scripts are executed line by line using execute(). It would be better to use Doctrine transactions in order to manage rollback and stuff and enhance speed.

@iammichiel
Copy link
Contributor

From MySQL documentation :

Statements That Cause an Implicit Commit

  • Data definition language (DDL) statements that define or modify database objects.
  • Statements that implicitly use or modify tables in the mysql database.

One of the points of this extension was to create views, create indexes, etc. that can not be created by Doctrine. If we implement the transaction process no creation or alter tabel can be used in the SQL scripts, thus taking away part of it's benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants