Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why add arbitrary command execution? #135

Open
PetFeld-ed opened this issue Jun 26, 2024 · 0 comments
Open

Question: Why add arbitrary command execution? #135

PetFeld-ed opened this issue Jun 26, 2024 · 0 comments

Comments

@PetFeld-ed
Copy link

Before describing my question, I would like to thank you for this tool. It is really helpful for ensuring system stability with Docker containers when you need to expect that a container might become unhealthy in production.

I am wondering what the reason for the if/else in the docker-entrypoint file in lines 130 and 178 is.
If autoheal is passed as first parameter, the entrypoint does the container checking and restarting. But if something else is provided, it is just passed to exec in line 179.

I can see, that there might be use cases for this (passing another command to the container for test purpose). But I question whether this is really a good decision security-wise for a container that gets access to the Docker socket in production.

Is there something I'm missing here or is this line really just for ease of testing by providing another command to the container?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant