-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add support for CSS variables present in remote @import
urls
#63
Comments
Parsing CSS in node_modules is still possible using extension settings, but parsing remote CSS files isn't possible yet. |
@phoenisx curious how to do this? i am trying to use open props with this extension and the only way i could figure out how to recognise the files was by removing is there a more efficient way? p.s. i love what you're doing here. it has motivated me to write normal css again (instead of css-in-js) for the first time in yeeears! |
Thanks for your kind words and support @jjenzz, and also for bringing this issue to my notice. To summarize your statement above, you are saying the extension works, but there are too many duplicates, am I correct? I have a working example for Let me fix this by today, and I was also thinking to add a config that when enabled, will dedupe all duplicate declarations parsed from all source files, keeping just their location references to navigate to the definition. |
Adding more context here, for visibility:
|
thanks for that! not sure why i hadn't looked there before 🙈 sorry. i have tried the following configuration today which doesn't have any duplicates but i only get colours in my inteilisense (not sizes etc): {
"cssvar.themes": ["dark"],
"cssvar.disableSort": true,
"cssvar.ignore": ["**/build"],
"cssvar.files": ["app/**/*.css", "node_modules/open-props/open-props.min.css"],
"cssvar.excludeThemedVariables": true,
} intellisense: i am using pnpm if that helps at all. would you like me to raise a GH issue for this or is there something i am missing? |
Hi @jjenzz out.mp4Can you try disabling all installed extensions and enabling just this one to validate if some other extension is not causing any conflict? If the issue still persists, please do raise an issue with the following details:
|
i figured out what it was. i had seen in another GH issue that adding the following to "[css]": {
"editor.suggest.showVariables": false
}, removing this configuration fixes it :) thanks for all your time on this, if there is any way i can send a donation of support please do let me know. i'd love to help you to continue maintaining the extension. |
@jjenzz great to hear that you solved the issue.
I appreciate your support 🙏🏽 🙇🏽 🙌🏽. |
@import
can support a lot of types of CSS functions, and when used withurl
function, it can also be used to fetch CSS from remote URLs. E.g.Ref:
TODO
node_modules
.The text was updated successfully, but these errors were encountered: