Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legalIdentifier spec and examples are inconsistent #8

Open
kvakes opened this issue Jul 10, 2020 · 1 comment
Open

legalIdentifier spec and examples are inconsistent #8

kvakes opened this issue Jul 10, 2020 · 1 comment
Assignees

Comments

@kvakes
Copy link
Member

kvakes commented Jul 10, 2020

In orgid-json-schema.yaml file it's just a "string" (example 1), while in vocabulary.md it is an object (example 2).

Example `:

    "legalEntity": {
        "legalName": "Acme, Corp.",
        "alternativeName": "Acme",
        "legalIdentifier": "US12345567",
        "identifiers":

Example 2:

{
    "type": "Commercial register number",
    "value": "CH-170.7.000.838-1"
}
@kvakes
Copy link
Member Author

kvakes commented Jul 10, 2020

Perhaps it's not a bad idea to do something like this though:

{
    "legalEntity": {
        "legalName": "Acme, Corp.",
        "legalIdentifier": {
            "authority": "California Secretary of State",
            "value": "CA12345567",
            "uri": "https://businesssearch.sos.ca.gov/"
        }
    }
}

@kvakes kvakes changed the title legalIdentifier examples are inconsistent legalIdentifier spec and examples are inconsistent Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants