Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message for compiling unknown platforms #5234

Closed
tsuf239 opened this issue Dec 17, 2023 · 4 comments
Closed

better error message for compiling unknown platforms #5234

tsuf239 opened this issue Dec 17, 2023 · 4 comments
Labels
🐛 bug Something isn't working ⌨️ cli CLI good first issue Good for newcomers needs-discussion Further discussion is needed prior to impl 👠 platforms Issues relating to Wing Platform Providers

Comments

@tsuf239
Copy link
Contributor

tsuf239 commented Dec 17, 2023

I tried this:

I wanted to test wing code the awscdk target, I didn't have it installed on my machine.
I ran:
wing test -t @winglang/platform-awscdk path-to-file

This happened:

image

I expected this:

Wing cli to display a friendly error such as "seems like "platform-name" isn't installed, try running npm i -g <package name>?"
*I assume that the same error is displayed even for mistyped or unexisting platforms, please take that in account
@hasanaburayyan do you have an idea for a friendly error message to display?

Is there a workaround?

No response

Anything else?

Dear contributor, you are welcome to assign yourself to the task! before you start, please verify that you have the exact wording for the error message and that edge cases are all covered :)

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@tsuf239 tsuf239 added 🐛 bug Something isn't working ⌨️ cli CLI good first issue Good for newcomers needs-discussion Further discussion is needed prior to impl 👠 platforms Issues relating to Wing Platform Providers labels Dec 17, 2023
@monadabot monadabot added this to Wing Dec 17, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New - not properly defined in Wing Dec 17, 2023
@staycoolcall911 staycoolcall911 moved this from 🆕 New - not properly defined to 🤝 Backlog - handoff to owners in Wing Dec 17, 2023
Copy link

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@revitalbarletz
Copy link
Contributor

@srinumadhavv let me know what do you think about this issue!

@srinumadhavv
Copy link
Contributor

@Chriscbr @revitalbarletz image
Seems the error comes from here but its still picking up the old change as per the description any headsup at where to start looking at ?

@tsuf239
Copy link
Contributor Author

tsuf239 commented May 26, 2024

found a duplication to this issue- #6147
and it seems like it was closed by @hasanaburayyan in #6176
I think we can close this one :)
@srinumadhavv please let us know if you need help choosing another issue

@tsuf239 tsuf239 closed this as completed May 26, 2024
@github-project-automation github-project-automation bot moved this from 🤝 Backlog - handoff to owners to ✅ Done in Wing May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⌨️ cli CLI good first issue Good for newcomers needs-discussion Further discussion is needed prior to impl 👠 platforms Issues relating to Wing Platform Providers
Projects
Archived in project
Development

No branches or pull requests

4 participants