Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion issue in for statement #6233

Closed
eladb opened this issue Apr 14, 2024 · 1 comment · Fixed by #6240
Closed

Completion issue in for statement #6233

eladb opened this issue Apr 14, 2024 · 1 comment · Fixed by #6240
Labels
🐛 bug Something isn't working 📡 language-server IDE Support

Comments

@eladb
Copy link
Contributor

eladb commented Apr 14, 2024

I tried this:

Screen.Recording.2024-04-14.at.11.30.06.mov

This happened:

See above

I expected this:

No response

Is there a workaround?

No response

Anything else?

No response

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@eladb eladb added the 🐛 bug Something isn't working label Apr 14, 2024
@monadabot monadabot added this to Wing Apr 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New - not properly defined in Wing Apr 14, 2024
@MarkMcCulloh MarkMcCulloh mentioned this issue Apr 15, 2024
Merged
@mergify mergify bot closed this as completed in #6240 Apr 15, 2024
mergify bot pushed a commit that referenced this issue Apr 15, 2024
@MarkMcCulloh
fix: cascading parser errors from incomplete block statements (if/`…
9776284 
…for`/etc.) (#6240)

Fixes #6233
Fixes #6180

Primary goal was to fix the above completions issues, but all that was needed was to improve the parser so that the language server has better information to work with.

Before
<img width="719" alt="image" src="https://github.com/winglang/wing/assets/1237390/a71b2a2a-09dc-4752-92a1-7cb6baac2679">

After
<img width="609" alt="image" src="https://github.com/winglang/wing/assets/1237390/4d3f722d-e2ef-41e2-a6f0-e6945cb53e18">


*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@github-project-automation github-project-automation bot moved this from 🆕 New - not properly defined to ✅ Done in Wing Apr 15, 2024
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.70.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 📡 language-server IDE Support
Projects
Wing
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cascading parser errors from incomplete block statements (if/for/etc.) winglang/wing
3 participants
@eladb @MarkMcCulloh @monadabot