Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

favicon icons don't need rel="shortcut icon" - can just be rel="icon" #2112

Closed
1 task
coliff opened this issue Jul 8, 2024 · 1 comment · May be fixed by #2646
Closed
1 task

favicon icons don't need rel="shortcut icon" - can just be rel="icon" #2112

coliff opened this issue Jul 8, 2024 · 1 comment · May be fixed by #2646

Comments

@coliff
Copy link

coliff commented Jul 8, 2024 •
edited
Loading

What version of starlight are you using?

0.25.0

What version of astro are you using?

4.11.5

What package manager are you using?

npm

What operating system are you using?

Windows

What browser are you using?

Edge

Describe the Bug

image

No need for rel="shortcut icon", should be just rel="icon".

shortcut is not, and never has been, a valid link relation. Read this amazing article by Mathias Bynens from ten years ago that explains why we never needed shortcuts and why rel="icon" is just fine.

(from: https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs)

Link to Minimal Reproducible Example

n/a

Participation

  • I am willing to submit a pull request for this issue.
@coliff coliff changed the title favicon icons don't need 'shortcut' favicon icons don't need rel="shortcut icon" - can just be rel="icon" Jul 8, 2024
@delucis
Copy link
Member

delucis commented Jul 8, 2024

Thanks for the issue @coliff! I’m not sure this rises to the level of a bug if nothing is breaking?

The HTML spec was updated since that initial article was written to say:

For historical reasons, the icon keyword may be preceded by the keyword "shortcut". If the "shortcut" keyword is present, the rel attribute's entire value must be an ASCII case-insensitive match for the string "shortcut icon" (with a single U+0020 SPACE character between the tokens and no other ASCII whitespace).

Would welcome a PR cleaning this up though if you’re interested 🙌

@delucis delucis closed this as completed Jul 8, 2024
@techfg techfg mentioned this issue Nov 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove rel shortcut from favicon techfg/starlight
2 participants
@delucis @coliff