Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with server side Rendering #63

Open
ElesGergo opened this issue May 22, 2020 · 2 comments
Open

Issue with server side Rendering #63

ElesGergo opened this issue May 22, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ElesGergo
Copy link

ERROR TypeError: this.imageThumbnail.nativeElement.getBoundingClientRect is not a function
@ElesGergo ElesGergo reopened this May 22, 2020
@ElesGergo ElesGergo changed the title Add support for SSR Issue with server side Rendering May 22, 2020
@wittlock
Copy link
Owner

wittlock commented Jun 7, 2020

I haven't really looked into server side rendering at all. I'm not sure I'll get around to figuring that out and how to get this library to still work as intended anytime soon. I'd be happy to look over a pull request though.

@wittlock wittlock added enhancement New feature or request help wanted Extra attention is needed labels Jun 7, 2020
@urohith17 urohith17 mentioned this issue Nov 22, 2020
Closed
@urohith17 urohith17 mentioned this issue Nov 29, 2020
Closed
@ghost
Copy link

ghost commented Oct 27, 2023

According to the latest code in master this issue should not occur now as the calculation is done after the image load which will be triggered at browser side. I tested in ssr environment and verified it. This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix getBoundingClientRect error in ssr applications
2 participants
@wittlock @ElesGergo