Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRC colors: "Open (null)" when trying to open certain URLs #18

Open
reedy opened this issue Jan 25, 2020 · 2 comments
Open

IRC colors: "Open (null)" when trying to open certain URLs #18

reedy opened this issue Jan 25, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@reedy
Copy link

reedy commented Jan 25, 2020

As requested on IRC, I'm reporting that it's possible to click on a link in iQuassel and get a menu item that says "Open (null)"

Currently on a plane, no data on my mobile, so can't check the iQuassel version. However, it's not a recent regression

Will come back later with an example IRC line too for a reproducible case

@guruz
Copy link
Member

guruz commented Jan 25, 2020

Adding this from IRC:

<Reedy> IIRC, it's a URL prefixed by IRC colour control characters and it gets messed up

@guruz guruz self-assigned this Jan 25, 2020
@reedy
Copy link
Author

reedy commented Jan 25, 2020

So, an example IRC line is (seems github doesn't display it as raw text)

[11:24] <wikibugs> (�03PS2�) �10�C. Scott Ananian�: WIP: Make private a number of methods not invoked outside the Parser class [core] - �10https://gerrit.wikimedia.org/r/567250�

IMG_4773

For reference, but maybe not relevant: iPhone 8, iOS 13.3. iQuassel 1.8.2

@guruz guruz changed the title "Open (null)" when trying to open certain URLs IRC colors: "Open (null)" when trying to open certain URLs Jan 27, 2020
@guruz guruz added the bug Something isn't working label Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants