Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultChangeDetector misses commits which are authored before from Date #51

Open
Larusso opened this issue Aug 18, 2021 · 0 comments
Open

Comments

@Larusso
Copy link
Member

Larusso commented Aug 18, 2021

Description

The DefaultChangeDetector will do an initial scan of all commits between two dates. Commits that where authored before the from date but later merged into the branch to be checked will be skipped.

Date fromDate = (from) ? from.commitDate : null
Date toDate = to.commitDate
if (fromDate && toDate && (fromDate > toDate)) {
throw new ChangeDetectorException("Commit ${from.SHA1} is newer than ${to.SHA1}")
}

The desired behavior is to produce the same log as git locally would do.

git log from..to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant