safari에서 작동되지 않거나 의도한대로 보이지 않는 부분 수정 및 기타 이슈 #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡️ Lighthouse report!
|
inyeong-kang
approved these changes
Oct 26, 2023
| // expect(result.current.getPageNumberList(totalPage)).toEqual(expected); | ||
| // } | ||
| // ); | ||
|
|
| @@ -14,6 +14,8 @@ export const Container = styled.div` | |||
| @media (min-width: ${theme.breakpoint.sm}) { | |||
| font: var(--text-body); | |||
| } | |||
|
|
|||
| z-index: 1; | |||
|
사파리에서 모달이 닫히지 않는 이유로는 개발자 도구를 찍어보니 다이어로그 콘텐츠 안의 사각형을 위치를 계산하는 로직이 좀 다른 것 같아요 |
|
이걸 오늘 해결해버리셨네요 |
chsua
approved these changes
Oct 29, 2023
|
fe-리뷰완 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
close: #823
close: #824
close: #825
📝 작업 요약
⏰ 소요 시간
30분
🔎 작업 상세 설명
개선 전
개선 후