Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split identity insertion to more phases #492

Open
cichaczem opened this issue Apr 24, 2023 · 2 comments
Open

Split identity insertion to more phases #492

cichaczem opened this issue Apr 24, 2023 · 2 comments
Assignees
@cichaczem

Comments

@cichaczem
Copy link
Contributor

Goal:

  • Make /insertIdentity endpoint independent from adding identity to the tree and submitting to the chain
  • Increase this API endpoint availability

Problem:

  • Sequencer builds a local tree of identities on the startup
  • This makes the API unresponsive

Proposed solution:

  • New identities are added to the DB with a status indicating they are not in the tree yet
  • Startup with building local tree happens asynchronously
  • When the local tree is ready, the app processes awaiting identities
  • Chain submission process works as is
@cichaczem
Copy link
Contributor Author

Partially related to https://github.com/orgs/worldcoin/projects/4/views/1?filterQuery=stat&pane=issue&itemId=26170286

@cichaczem cichaczem self-assigned this May 9, 2023
@cichaczem
Copy link
Contributor Author

Open questions:

  • Does anyone rely on /insertIdentity return value?
  • We want to change the response of /inclusionProof when identity was not processed yet. What will it break?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cichaczem cichaczem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cichaczem