In regard to Jump Counter-Exploit, please upgrade Token contract to allow rescuing of ERC20 like USDC #2442
-
Description and contextFirst and foremost, congratulations on successfully recovering $225M of assets in stolen funds using an upgradable proxy contract on Oasis AutomationBot contract. A similar approach of using upgradable proxy contract can be implemented here to rescue assets trapped on wormhole contracts, for example ERC20 tokens. Implement a rescueERC20 function with appropriate AccessControl (i.e. assigning 'rescuer' role to the deployer or owner) and upgrade exiting Token contracts. Main take aways being:
The immdiate contract in question is: UST (Wormhole) on Polygon
Definition of doneToken contract allows trapped funds/assets to be recovered. Lastly, congrates again on recoving of the stolen funds. Hope you will demonstrate professionalism and good will here for other users in the same situation. |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments
-
Hey, thanks for the detailed writeup and providing context! I'm going to focus on the technical content of your proposal, as I'm not familiar with the details of the Oasis protocol or any ongoing litigation. Jump Crypto is one of 19 guardians that govern the Wormhole protocol, and any protocol change requires a supermajority (i.e. 2/3+) consensus of the guardians, so any potential way forward will require the guardians to agree, and not something that an individual entity can single-handedly decide. With that being said, here are my personal thoughts on the proposal:
|
Beta Was this translation helpful? Give feedback.
-
Thanks for your response. A few more examples I should have provided:
This should answer your point in regard to security audits, afaik security audits cost a few k(s) and up but the above token addresses have more than 1 million worth of retail user worth of tokens/assets trapped under wormhole's Token addresses. Yes, you could argue both meta mask and ERC20 should have prevented this from happening, more discussion here: Back to the topic of the existing fund being stuck on Token contracts which are upgradable proxy contracts. Yes, the rescuer would be the guardian multi-sig from the sound of it. On cheaper chains like polygon pos where the rescue operation is relatively low cost, you guys should just send the trapped tokens back to each address to show a form of goodwill after the Jump incident. For the Ethereum blockchain, there should be a type of form (Tally or Typeform) for retail users to fill and forfeit a percentage of the trapped fund as rescue operation cost, how ever you guys deem it's sensible to charge the fees. |
Beta Was this translation helpful? Give feedback.
-
Hi @kcsongor, Coming back to this topic, USDC appears to have implemented a FiatTokenV2_1 upgrade (on Jan 26, 2021) here: The solution seems rather simple, it performs a one-time 'rescue' operation to existing token addresses, sends the 'stuck' fund to a nominated address and you do not need to deal with things like It also prevents future funds being miss-sent to the token contract by using it's internal 'blacklist' mechanism, again it's rather neat + straightforward. I hope your team can go through the old and existing wormhole smart contracts deployed on all major chains and analyse the sum of all stuck / miss-sent funds, because the amount is substantial:
It is very risky to leave the stuck tokens in an abandoned token contract (UST) which had already depegged, please consider this alternative approach. |
Beta Was this translation helpful? Give feedback.
-
Congratulations on the $W token launch. Are there any plans to use some of the resource from the token launch to work on old/backlog issues like these? Kind regards. |
Beta Was this translation helpful? Give feedback.
Hey, thanks for the detailed writeup and providing context!
I'm going to focus on the technical content of your proposal, as I'm not familiar with the details of the Oasis protocol or any ongoing litigation.
Jump Crypto is one of 19 guardians that govern the Wormhole protocol, and any protocol change requires a supermajority (i.e. 2/3+) consensus of the guardians, so any potential way forward will require the guardians to agree, and not something that an individual entity can single-handedly decide.
With that being said, here are my personal thoughts on the proposal: