-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
size command doesn't work with SQLite #243
Comments
I don't think it's likely that WordPress core will add exactly what we need.
I'm open to it! I'd suggest we fix SQLite support for a couple/few commands first, and then figure out what abstraction they need.
Worth noting:
Here's what I see with SQLite:
|
The following only works with MySQL
db-command/src/DB_Command.php
Lines 1019 to 1024 in 0908bf5
I don't believe there is a similar way to get the size of a SQLite database, and the preferred method is to just get the size of the .sqlite file itself.
I wonder what the general solution should be to detect SQLite use in wp-cli commands so any new code is consistent across various projects? It could be good to have a helper function to give the current database type and maybe also the location of the .sqlite file if it is SQLite.
Or is this just better left until WordPress adopts SQLite officially and adds a built in method for wbdp?
The text was updated successfully, but these errors were encountered: