Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prompt to save layout when closing #173

Closed
nightpool opened this issue Sep 6, 2017 · 2 comments
Closed

prompt to save layout when closing #173

nightpool opened this issue Sep 6, 2017 · 2 comments
Assignees
@nightpool
Milestone
2018 Beta 2

Comments

@nightpool
Copy link
Contributor

Maybe should also keep track of whether the layout is unsaved/dirty? Doing that seems complicated.
@nightpool
Copy link
Contributor Author

Possible approach: do JSON serialization, canonicalize, and compare to current layout. (or do a tree diff)

@nightpool nightpool added this to the Alpha milestone Sep 6, 2017
@nightpool nightpool self-assigned this Sep 6, 2017
@SamCarlberg
Copy link
Member

I did something similar for GRIP, which heavily relies on the event bus model for knowing when a "save-changing" event occurs. The issue with shuffleboard is that we need to know when users change the scene graph as well as widget properties and layout preferences

@bradamiller bradamiller modified the milestones: Alpha, Beta, Beta 2 Sep 28, 2017
SamCarlberg added a commit to SamCarlberg/shuffleboard that referenced this issue Nov 21, 2017
@SamCarlberg
Ask to save the current layout when closing shuffleboard
db3f3ef 
Fixes wpilibsuite#173
@SamCarlberg SamCarlberg mentioned this issue Nov 21, 2017
Merged
bradamiller pushed a commit that referenced this issue Nov 22, 2017
@SamCarlberg @bradamiller
Ask to save the current layout when closing shuffleboard (#307)
c564f64 
* Ask to save the current layout when closing shuffleboard

Fixes #173

* Set title, improve message text

* Add option to not show exit confirmation dialog

* Show confirmation dialog on File -> Close

Changes the MainWindowController.close() method to attempt to close the window rather than terminating the program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nightpool nightpool

Labels
None yet
Projects
None yet
Milestone
2018 Beta 2
Development

No branches or pull requests
3 participants
@nightpool @bradamiller @SamCarlberg